Skip to content

[Tests] Fix De-/serialization tests of HighlightBuilder #69259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2021
Merged

[Tests] Fix De-/serialization tests of HighlightBuilder #69259

merged 1 commit into from
Feb 19, 2021

Conversation

matriv
Copy link
Contributor

@matriv matriv commented Feb 19, 2021

Assign a value different that the original when testing
mutation of the builder.

Previously reproduced with:

2> REPRODUCE WITH: ./gradlew ':server:test' --tests "org.elasticsearch.search.fetch.subphase.highlight.HighlightBuilderTests.testEqualsAndHashcode" -Dtests.seed=5BFC4C9C89309FA8 -Dtests.security.manager=true -Dtests.locale=is-IS -Dtests.timezone=America/Sao_Paulo -Druntime.java=11 |  
-- | --
  | 2> java.lang.AssertionError: HighlightBuilder mutation should not be equal to original

Follows: #67325

@matriv
[Tests] Fix De-/serialization tests of HighlightBuilder
f0f459e 
Assign a value different that the original when testing
mutation of the builder.

Follows: elastic#67325
@matriv matriv added :Search Relevance/Highlighting How a query matched a document >test-failure Triaged test failures from CI v8.0.0 v7.13.0 v7.12.1 labels Feb 19, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Feb 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

romseygeek
romseygeek approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matriv matriv merged commit 4a6c957 into elastic:master Feb 19, 2021
@matriv matriv deleted the fix-HighlightBuilderTests branch February 19, 2021 11:38
matriv added a commit that referenced this pull request Feb 19, 2021
@matriv
[Tests] Fix De-/serialization tests of HighlightBuilder (#69259)
5c5f3ff 
Assign a value different that the original when testing
mutation of the builder.

Follows: #67325
(cherry picked from commit 4a6c957)
matriv added a commit that referenced this pull request Feb 19, 2021
@matriv
[Tests] Fix De-/serialization tests of HighlightBuilder (#69259)
2bcd0b6 
Assign a value different that the original when testing
mutation of the builder.

Follows: #67325
(cherry picked from commit 4a6c957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees
No one assigned
Labels
:Search Relevance/Highlighting How a query matched a document Team:Search Meta label for search team >test-failure Triaged test failures from CI v7.12.1 v7.13.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matriv @elasticmachine @romseygeek @jakelandis