Fix string replacement in certutil http test #69319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test had 2 issues: 1. It performed a replacement using a string literal on a randomly generated string. It is possible that the filename had ".csr" somewhere in the basename, which would then produce incorrect results 2. It used the wrong base file for the substitution (key vs csr). This fixes the bug by using an index based replacement rather than a textual one. Resolves: elastic#67328
tvernum
added
>test
|
Pinging @elastic/es-security (Team:Security) |
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Feb 23, 2021
This test had 2 issues: 1. It performed a replacement using a string literal on a randomly generated string. It is possible that the filename had ".csr" somewhere in the basename, which would then produce incorrect results 2. It used the wrong base file for the substitution (key vs csr). This fixes the bug by using an index based replacement rather than a textual one. Backport of: elastic#69319
tvernum
added a commit
that referenced
this pull request
Feb 23, 2021
This test had 2 issues: 1. It performed a replacement using a string literal on a randomly generated string. It is possible that the filename had ".csr" somewhere in the basename, which would then produce incorrect results 2. It used the wrong base file for the substitution (key vs csr). This fixes the bug by using an index based replacement rather than a textual one. Backport of: #69319
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Feb 23, 2021
This test had 2 issues: 1. It performed a replacement using a string literal on a randomly generated string. It is possible that the filename had ".csr" somewhere in the basename, which would then produce incorrect results 2. It used the wrong base file for the substitution (key vs csr). This fixes the bug by using an index based replacement rather than a textual one. Backport of: elastic#69319 Backport of: elastic#69404
tvernum
added a commit
that referenced
this pull request
Feb 25, 2021
This test had 2 issues: 1. It performed a replacement using a string literal on a randomly generated string. It is possible that the filename had ".csr" somewhere in the basename, which would then produce incorrect results 2. It used the wrong base file for the substitution (key vs csr). This fixes the bug by using an index based replacement rather than a textual one. Backport of: #69319, #69404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test had 2 issues:
generated string. It is possible that the filename had ".csr"
somewhere in the basename, which would then produce incorrect results
This fixes the bug by using an index based replacement rather than a
textual one.
Resolves: #67328