Skip to content

Terms aggs that run as filters ignore shard_min_doc_count #69323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Feb 22, 2021

This change handles shard_min_doc_count for terms aggregation that run as filters.

Relates #68871
Closes #69312

This change handles `shard_min_doc_count` for terms aggregation that run as filters.

Closes elastic#69312
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks for fixing my mistake!

@jimczi jimczi merged commit 27c31fa into elastic:master Feb 22, 2021
@jimczi jimczi deleted the terms_shard_min_doc_count branch February 22, 2021 12:16
nik9000 pushed a commit to nik9000/elasticsearch that referenced this pull request Feb 22, 2021
)

This change handles `shard_min_doc_count` for terms aggregation that run as filters.

Closes elastic#69312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.13.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] TermsShardMinDocCountIT.testShardMinDocCountTermsTest failing
4 participants