Migrate watcher to system indices infrastructure (#67588) #69328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of elastic#61656. Migrate the `.watches` and `.triggered_watches` system indices to use the auto-create infrastructure. The watcher history indices are left alone. As part of this work, a `SystemIndexDescriptor` now inspects its mappings to determine whether it has any dynamic mappings. This influences how strict Elasticsearch is with enforcing the descriptor's mappings, since ES cannot know in advanced what all the mappings will be. This PR also fixes the `SystemIndexManager` so that (1) it doesn't fall over when attempting to inspect the state of an index that hasn't been created yet, and (2) does update mappings if there's no version field in the mapping metadata.
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
masseyke
added a commit
that referenced
this pull request
Jan 13, 2022
) This commit prevents watcher from failing to start if its templates are unavailable. Previously the watcher service would fail to start if (for example) the .watch-history-14 template did not exist. This could happen during a rolling upgrade. In that case, the watcher service would fail to start even though it could reasonably keep writing without its templates. Relates #69328 #82109
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Jan 13, 2022
…stic#82395) This commit prevents watcher from failing to start if its templates are unavailable. Previously the watcher service would fail to start if (for example) the .watch-history-14 template did not exist. This could happen during a rolling upgrade. In that case, the watcher service would fail to start even though it could reasonably keep writing without its templates. Relates elastic#69328 elastic#82109
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Jan 13, 2022
…stic#82395) This commit prevents watcher from failing to start if its templates are unavailable. Previously the watcher service would fail to start if (for example) the .watch-history-14 template did not exist. This could happen during a rolling upgrade. In that case, the watcher service would fail to start even though it could reasonably keep writing without its templates. Relates elastic#69328 elastic#82109
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 13, 2022
) (#82573) This commit prevents watcher from failing to start if its templates are unavailable. Previously the watcher service would fail to start if (for example) the .watch-history-14 template did not exist. This could happen during a rolling upgrade. In that case, the watcher service would fail to start even though it could reasonably keep writing without its templates. Relates #69328 #82109
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 13, 2022
) (#82572) This commit prevents watcher from failing to start if its templates are unavailable. Previously the watcher service would fail to start if (for example) the .watch-history-14 template did not exist. This could happen during a rolling upgrade. In that case, the watcher service would fail to start even though it could reasonably keep writing without its templates. Relates #69328 #82109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #67588. Part of #61656.
Migrate the
.watchesand.triggered_watchessystem indices to usethe auto-create infrastructure. The watcher history indices are left
alone.
As part of this work, a
SystemIndexDescriptornow inspects itsmappings to determine whether it has any dynamic mappings. This
influences how strict Elasticsearch is with enforcing the descriptor's
mappings, since ES cannot know in advanced what all the mappings will
be.
This PR also fixes the
SystemIndexManagerso that (1) it doesn't fallover when attempting to inspect the state of an index that hasn't been
created yet, and (2) does update mappings if there's no version field in
the mapping metadata.