Improve awareness allocation explanation #69371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users sometimes struggle with unassigned shards due to the awareness decider, especially if the decider is using more zones than expected (e.g. a typo in an attribute value, or a stale forced-awareness config). It is hard to see why there are more zones than expected, or even really to tell from the message that this is the problem. This commit adds detail about the names of the zones that the allocation decider is using, so that users can see for themselves whether that is the source of the problem, and rewords it slightly to make it easier to understand.
DaveCTurner
added
>enhancement
:Distributed Coordination/Allocation
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
commented
Feb 22, 2021
| testExplanation(Settings.builder() | ||
| .put(AwarenessAllocationDecider.CLUSTER_ROUTING_ALLOCATION_AWARENESS_ATTRIBUTE_SETTING.getKey(), "zone"), | ||
| n -> n.add(newNode("X-0", emptyMap())), | ||
| "there are [5] copies of this shard and [3] values for attribute [zone] ([<missing>, a, b] from nodes in the cluster and " + |
There was a problem hiding this comment.
On reflection I think this is a bug, we should be ignoring nulls completely, and although it didn't really matter in the past it does matter now. I opened #69374.
DaveCTurner
added a commit
that referenced
this pull request
Feb 23, 2021
Users sometimes struggle with unassigned shards due to the awareness decider, especially if the decider is using more zones than expected (e.g. a typo in an attribute value, or a stale forced-awareness config). It is hard to see why there are more zones than expected, or even really to tell from the message that this is the problem. This commit adds detail about the names of the zones that the allocation decider is using, so that users can see for themselves whether that is the source of the problem, and rewords it slightly to make it easier to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users sometimes struggle with unassigned shards due to the awareness
decider, especially if the decider is using more zones than expected
(e.g. a typo in an attribute value, or a stale forced-awareness config).
It is hard to see why there are more zones than expected, or even really
to tell from the message that this is the problem.
This commit adds detail about the names of the zones that the allocation
decider is using, so that users can see for themselves whether that is
the source of the problem, and rewords it slightly to make it easier to
understand.