-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Delete data stream in ILM delete action if last index in data stream #69637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an index happens to be the last index in the data stream (such as a user testing ILM out) when it comes to the `delete` action, we attempt to delete it, however, a data stream cannot be empty, so it throws an exception and prevents the deletion. This commit changes the behavior of the `delete` action such that deleting the very last index in a data stream deletes the entire data stream.
Pinging @elastic/es-core-features (Team:Core/Features) |
martijnvg
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andreidan
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Lee
This was referenced Mar 1, 2021
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 1, 2021
…lastic#69637) If an index happens to be the last index in the data stream (such as a user testing ILM out) when it comes to the `delete` action, we attempt to delete it, however, a data stream cannot be empty, so it throws an exception and prevents the deletion. This commit changes the behavior of the `delete` action such that deleting the very last index in a data stream deletes the entire data stream.
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 1, 2021
…lastic#69637) If an index happens to be the last index in the data stream (such as a user testing ILM out) when it comes to the `delete` action, we attempt to delete it, however, a data stream cannot be empty, so it throws an exception and prevents the deletion. This commit changes the behavior of the `delete` action such that deleting the very last index in a data stream deletes the entire data stream.
dakrone
added a commit
that referenced
this pull request
Mar 1, 2021
…stream (#69637) (#69724) If an index happens to be the last index in the data stream (such as a user testing ILM out) when it comes to the `delete` action, we attempt to delete it, however, a data stream cannot be empty, so it throws an exception and prevents the deletion. This commit changes the behavior of the `delete` action such that deleting the very last index in a data stream deletes the entire data stream.
dakrone
added a commit
that referenced
this pull request
Mar 1, 2021
…tream (#69637) (#69723) If an index happens to be the last index in the data stream (such as a user testing ILM out) when it comes to the `delete` action, we attempt to delete it, however, a data stream cannot be empty, so it throws an exception and prevents the deletion. This commit changes the behavior of the `delete` action such that deleting the very last index in a data stream deletes the entire data stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Data Management/ILM+SLM
Index and Snapshot lifecycle management
Team:Data Management
Meta label for data/management team
v7.12.1
v7.13.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an index happens to be the last index in the data stream (such as a user testing ILM out) when it
comes to the
delete
action, we attempt to delete it, however, a data stream cannot be empty, so itthrows an exception and prevents the deletion.
This commit changes the behavior of the
delete
action such that deleting the very last index in adata stream deletes the entire data stream.