Added pre and post offset to histogram aggregation #6980
Conversation
| @@ -127,6 +127,59 @@ public void writeTo(StreamOutput out) throws IOException { | |||
| out.writeVLong(interval); | |||
| } | |||
| } | |||
|
|
|||
| public static class PrePostIntervalRounding extends TimeZoneRounding { | |||
There was a problem hiding this comment.
This looks very similar to PrePostTimeZoneRounding. Do you think we can reuse it?
There was a problem hiding this comment.
So I tried doing that and creating a PrePostRounding which extended Rounding, but TimeZoneRounding.Builder expects everything thats returned to be an instance of TimeZoneRounding so would mean changing FactorTimeZoneRounding to accept a Rounding delegate and change the build() method to return Rounding instead of TimeZoneRounding. Not sure if that makes things too messy?
There was a problem hiding this comment.
TimeZoneRounding.Builder expects everything thats returned to be an instance of TimeZoneRounding
TimeZoneRounding doesn't add anything on top of Rounding so I think it's ok to return/expect Rounding instances here.
|
LGTM |
|
pushed to master and 1.x |
clintongormley
changed the title
Added preOffset and postOffset parameters to the API for the histogram aggregation which work in the same way as in the date histogram
Closes #6605