[Tests] Handle escape char correctly in wildcard patterns #69850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywangd
added
>test
|
Pinging @elastic/es-security (Team:Security) |
tvernum
reviewed
Mar 3, 2021
| @@ -26,10 +26,11 @@ public void testEmptySet() throws Exception { | |||
| public void testSingleWildcard() throws Exception { | |||
| final String prefix = randomAlphaOfLengthBetween(3, 5); | |||
| final StringMatcher matcher = StringMatcher.of(prefix + "*"); | |||
| final String normalisedPrefix = prefix.replace("\\", ""); | |||
There was a problem hiding this comment.
prefix cannot contain a \, it's alphabetic only.
| @@ -48,10 +49,11 @@ public void testUnicodeWildcard() throws Exception { | |||
| final String prefix = randomValueOtherThanMany(StringMatcherTests::hasHighSurrogate, | |||
| () -> randomRealisticUnicodeOfLengthBetween(3, 5)); | |||
| final StringMatcher matcher = StringMatcher.of(prefix + "*"); | |||
| final String normalisedPrefix = prefix.replace("\\", ""); | |||
There was a problem hiding this comment.
I would just push this up into the otherThanMany check.
randomValueOtherThanMany(StringMatcherTests::hasHighSurrogateOrBackslash
There was a problem hiding this comment.
Updated as suggested.
PS: I think we do need some tests for the behaviour of the escape char. This is not the right place for it. Maybe when fixing #69851.
tvernum
approved these changes
Mar 3, 2021
ywangd
added a commit
that referenced
this pull request
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape char is handled specially while building automaton. It should also be handled when buidling the target text for matching.
Resolves: #69837