Remove use of recycled set in filters eviction #7012
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -167,6 +166,8 @@ public void onRemoval(RemovalNotification<WeightedFilterCache.FilterCacheKey, Do | |||
| */ | |||
| class ReaderCleaner implements Runnable { | |||
|
|
|||
| private final ObjectOpenHashSet<Object> keys = ObjectOpenHashSet.newInstance(); | |||
There was a problem hiding this comment.
Is it thread-safe? If the cleanup takes very long I think this set might be used by two threads at the same time?
There was a problem hiding this comment.
yea, another cleanup is never scheduled until the first one ends
There was a problem hiding this comment.
Can you just leave a comment about it?
|
LGTM |
kimchy
added a commit
that referenced
this pull request
Jul 24, 2014
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.