Restrict ILM frozen phase to searchable snapshot actions only #70158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the frozen phase within ILM in the following ways: - The `searchable_snapshot` action now no longer takes a `storage` parameter. The storage type is determined by the phase within which it is invoked (shared cache for frozen and full copy for everything else). - The frozen phase in ILM now no longer allows *any* actions other than `searchable_snapshot` - If a frozen phase is provided, it *must* include a `searchable_snapshot` action. These changes may seem breaking, but since they are intended to go back to 7.12 which has not been released yet, they are not truly breaking changes.
dakrone
added
blocker
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-features (Team:Core/Features) |
dakrone
commented
Mar 9, 2021
Comment on lines
+192
to
+193
| boolean bwc_tests_enabled = false | ||
| String bwc_tests_disabled_issue = "https://github.com/elastic/elasticsearch/pull/70158" /* place a PR link here when committing bwc changes */ |
There was a problem hiding this comment.
This is required because I am removing the serialization for 7.12 in a weird way (we don't usually remove things like this), once this has been backported all the way back to 7.12 I will re-enable BWC
andreidan
approved these changes
Mar 9, 2021
| @@ -189,6 +192,17 @@ public static LifecyclePolicy randomTimeseriesLifecyclePolicy(@Nullable String l | |||
| } | |||
| phases.put(phase, new Phase(phase, after, actions)); | |||
| } | |||
| // Add a frozen phase if neither the hot nor cold phase contains a searchable snapshot action | |||
There was a problem hiding this comment.
What is the connection between the hot/cold actions and the frozen phase? We're still able to have searchable_snapshot actions in all phases as far as I understand
There was a problem hiding this comment.
It's mostly because we'd have to use a consistent repository name (or else validation would fail), we have enough validation that this gets more and more complex, and this doesn't have to generate all possible valid lifecycles, just a random one.
| @@ -413,6 +411,22 @@ public static String validateMonotonicallyIncreasingPhaseTimings(Collection<Phas | |||
| return Strings.collectionToCommaDelimitedString(errors); | |||
| } | |||
|
|
|||
| /** | |||
| * Require that all "frozen" phases configured in a policy have a searchable snapshot action. | |||
There was a problem hiding this comment.
uber nit :) but this implies the possible presence of multiple frozen phases in one policy and it might be confusing
There was a problem hiding this comment.
Good point, I changed this to not imply that.
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 9, 2021
…c#70158) This commit changes the frozen phase within ILM in the following ways: - The `searchable_snapshot` action now no longer takes a `storage` parameter. The storage type is determined by the phase within which it is invoked (shared cache for frozen and full copy for everything else). - The frozen phase in ILM now no longer allows *any* actions other than `searchable_snapshot` - If a frozen phase is provided, it *must* include a `searchable_snapshot` action. These changes may seem breaking, but since they are intended to go back to 7.12 which has not been released yet, they are not truly breaking changes.
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 9, 2021
…c#70158) This commit changes the frozen phase within ILM in the following ways: - The `searchable_snapshot` action now no longer takes a `storage` parameter. The storage type is determined by the phase within which it is invoked (shared cache for frozen and full copy for everything else). - The frozen phase in ILM now no longer allows *any* actions other than `searchable_snapshot` - If a frozen phase is provided, it *must* include a `searchable_snapshot` action. These changes may seem breaking, but since they are intended to go back to 7.12 which has not been released yet, they are not truly breaking changes.
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 9, 2021
With elastic#70158 (master), elastic#70170 (7.x), and elastic#70171 (7.12) merged, we can now re-enable backwards compatibilty tests on master and 7.x.
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 9, 2021
The action was recently removed from the list of acceptable actions (elastic#70158), the test shouldn't use it any more.
dakrone
added a commit
that referenced
this pull request
Mar 9, 2021
The action was recently removed from the list of acceptable actions (#70158), the test shouldn't use it any more.
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 9, 2021
The action was recently removed from the list of acceptable actions (elastic#70158), the test shouldn't use it any more.
dakrone
added a commit
that referenced
this pull request
Mar 9, 2021
The action was recently removed from the list of acceptable actions (#70158), the test shouldn't use it any more.
dakrone
added a commit
that referenced
this pull request
Mar 9, 2021
…70158) (#70171) * Restrict ILM frozen phase to searchable snapshot actions only (#70158) This commit changes the frozen phase within ILM in the following ways: - The `searchable_snapshot` action now no longer takes a `storage` parameter. The storage type is determined by the phase within which it is invoked (shared cache for frozen and full copy for everything else). - The frozen phase in ILM now no longer allows *any* actions other than `searchable_snapshot` - If a frozen phase is provided, it *must* include a `searchable_snapshot` action. These changes may seem breaking, but since they are intended to go back to 7.12 which has not been released yet, they are not truly breaking changes. * Fix compilation
dakrone
added a commit
that referenced
this pull request
Mar 9, 2021
dakrone
added a commit
that referenced
this pull request
Mar 9, 2021
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 9, 2021
…ic#70179) With elastic#70158 (master), elastic#70170 (7.x), and elastic#70171 (7.12) merged, we can now re-enable backwards compatibilty tests on master and 7.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the frozen phase within ILM in the following ways:
searchable_snapshotaction now no longer takes astorageparameter. The storage type isdetermined by the phase within which it is invoked (shared cache for frozen and full copy for
everything else).
searchable_snapshotsearchable_snapshotaction.These changes may seem breaking, but since they are intended to go back to 7.12 which has not been
released yet, they are not truly breaking changes.