-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[DOCS] More information on allowed profile names #70440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I did not find it clear in the existing documentation that while the `default` profile is special, other profiles could have any name, and are used for incoming connections (as the `default` profile is used for inter-node communication. I hope with this additional line it is a bit clearer.
Pinging @elastic/es-docs (Team:Docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM.
@DaveCTurner Would you mind providing an extra set of eyes? Thanks!
Pinging @elastic/es-distributed (Team:Distributed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit.
Thanks @robin13 @DaveCTurner! |
Co-authored-by: Robin Clarke <[email protected]>
Co-authored-by: Robin Clarke <[email protected]>
Co-authored-by: Robin Clarke <[email protected]>
I did not find it clear in the existing documentation that while the
default
profile is special, other profiles could have any name, and are used for incoming connections (as thedefault
profile is used for inter-node communication). I hope with this additional line it is a bit clearer.