Skip to content

[DOCS] More information on allowed profile names #70440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Conversation

robin13
Copy link
Contributor

@robin13 robin13 commented Mar 16, 2021

I did not find it clear in the existing documentation that while the default profile is special, other profiles could have any name, and are used for incoming connections (as the default profile is used for inter-node communication). I hope with this additional line it is a bit clearer.

robin13 added 2 commits March 16, 2021 09:46
I did not find it clear in the existing documentation that while the `default` profile is special, other profiles could have any name, and are used for incoming connections (as the `default` profile is used for inter-node communication. I hope with this additional line it is a bit clearer.
@matriv matriv added δλψσ >docs General docs changes and removed δλψσ labels Mar 23, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Mar 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

@DaveCTurner Would you mind providing an extra set of eyes? Thanks!

@jrodewig jrodewig requested a review from DaveCTurner March 24, 2021 13:01
@jrodewig jrodewig added :Distributed Coordination/Network Http and internode communication implementations v7.11.3 v7.12.1 v7.13.0 v8.0.0 labels Mar 24, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Mar 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@jrodewig jrodewig changed the title More information on allowed profile names [DOCS] More information on allowed profile names Mar 24, 2021
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit.

@jrodewig
Copy link
Contributor

Thanks @robin13 @DaveCTurner!

jrodewig added a commit that referenced this pull request Mar 24, 2021
jrodewig added a commit that referenced this pull request Mar 24, 2021
jrodewig added a commit that referenced this pull request Mar 24, 2021
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Network Http and internode communication implementations >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v7.11.3 v7.12.1 v7.13.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants