[7.x] ILM: Make all the shrink action steps retryable (#70107) #70573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aims at making the shrink action retryable. Every step is retryable, but in order to provide an experience where ILM tries to achieve a successful shrink even when the target node goes missing permanently or the shrunk index cannot recover, this also introduces a retryable shrink cycle within the shrink action. The shrink action will generate a unique index name that'll be the shrunk index name. The generated index name is stored in the lifecycle state. If the shrink action ends up waiting for the source shards to colocate or for the shrunk index to recover for more than the configured `LIFECYCLE_STEP_WAIT_TIME_THRESHOLD` setting, it will move back to clean up the attempted (and failed) shrunk index and will retry generating a new index name and attempting to shrink the source to the newly generated index name. (cherry picked from commit 9831084) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added
:Data Management/ILM+SLM
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
|
@elasticmachine run elasticsearch-ci/2 |
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims at making the shrink action retryable. Every step is
retryable, but in order to provide an experience where ILM tries
to achieve a successful shrink even when the target node goes
missing permanently or the shrunk index cannot recover, this also
introduces a retryable shrink cycle within the shrink action.
The shrink action will generate a unique index name that'll be the
shrunk index name. The generated index name is stored in the lifecycle
state.
If the shrink action ends up waiting for the source shards to
colocate or for the shrunk index to recover for more than the configured
LIFECYCLE_STEP_WAIT_TIME_THRESHOLDsetting, it will move backto clean up the attempted (and failed) shrunk index and will retry
generating a new index name and attempting to shrink the source
to the newly generated index name.
(cherry picked from commit 9831084)
Signed-off-by: Andrei Dan [email protected]
Backport of #70107