Fix exception when merging completion suggestions (#70414) #70633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under certain circumstances we can get "array_index_out_of_bounds" exceptions in the fetch phase when merging comletion suggestion results with additonal field collapsing in place. We store the ScoreDoc array in the SortedTopDocs score docs contain both regular search hits and completion suggestion results added in SearchPhaseController#sortDocs, so when merging these we need to know the correct array offset where the completion results begin. This is based on the hits length calculated in SearchPhaseController#getHits, which doesn't take into account that there might be suggestion results present when calculating the number of hits. This change adds the number of suggestions to SortedTopDocs in order to be able to later account for it when calculating the hits. Closes elastic#70328
cbuescher
force-pushed
the
fix-70414-bkp
branch
from
348a007 to
afa4725
Compare
|
@elasticmachine run elasticsearch-ci/bwc |
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances we can get "array_index_out_of_bounds" exceptions in
the fetch phase when merging comletion suggestion results with additonal field
collapsing in place. We store the ScoreDoc array in the SortedTopDocs score docs
contain both regular search hits and completion suggestion results added in
SearchPhaseController#sortDocs, so when merging these we need to know the
correct array offset where the completion results begin. This is based on the
hits length calculated in SearchPhaseController#getHits, which doesn't take into
account that there might be suggestion results present when calculating the
number of hits. This change adds the number of suggestions to SortedTopDocs in
order to be able to later account for it when calculating the hits.
Closes #70328