Manage Fleet system indices within Elasticsearch #70689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the management of seven system indices that are used by Fleet to an Elasticsearch plugin. The mappings were taken largely untouched from the Fleet server project, with the exception of adding a _meta field with a version key to enable the system indices infrastructure to manage these indices.
jaymode
added
>enhancement
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Thank you! |
|
@jaymode What are your thoughts on adding tests that verify the configuration and mappings of these system indices? On the one hand, we're adding some untested code here; on the other, this might be covered by the fleet tests already. |
|
@williamrandolph I agree that we want to add a basic verification test and I am planning to add one. I wanted to get this up sooner rather than later for the fleet team to verify |
williamrandolph
approved these changes
Apr 3, 2021
|
@jaymode we made some changes to mappings. will push the update later today. |
2 tasks
|
Jay, I tested e2e with the agent. There are couple of follow up PRs in the Kibana and Fleet Server. Should be good to merge now. |
3 tasks
jaymode
added a commit
that referenced
this pull request
Apr 7, 2021
This commit moves the management of seven system indices that are used by Fleet to an Elasticsearch plugin. The mappings were taken largely untouched from the Fleet server project, with the exception of adding a _meta field with a version key to enable the system indices infrastructure to manage these indices. Co-authored-by: Aleksandr Maus <[email protected]> Backport of #70689
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the management of seven system indices that are used
by Fleet to an Elasticsearch plugin. The mappings were taken largely
untouched from the Fleet server project, with the exception of adding
a _meta field with a version key to enable the system indices
infrastructure to manage these indices.