Add searchable snapshots integration tests for URL repositories #70709
Conversation
fcofdez
added
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
| @@ -18,13 +18,15 @@ | |||
| import java.nio.file.Paths; | |||
| import java.util.HashMap; | |||
| import java.util.Map; | |||
| import java.util.regex.Matcher; | |||
| import java.util.regex.Pattern; | |||
|
|
|||
| /** | |||
| * This {@link URLFixture} exposes a filesystem directory over HTTP. It is used in repository-url | |||
| * integration tests to expose a directory created by a regular FS repository. | |||
| */ | |||
| public class URLFixture extends AbstractHttpFixture { | |||
There was a problem hiding this comment.
This is a fixture. I was wondering if we could plug in Nginx or some other simple http server to really make sure it works with at least a proper http server.
There was a problem hiding this comment.
That's a good idea, I'll add a real http server to the test suite 👍
| } | ||
|
|
||
| for (repoDir in project.ext.fsRepositoryDirs) { | ||
| delete(repoDir.value as File) |
There was a problem hiding this comment.
It's odd that we would delete / recreate the directory at configuration time of the build?
There was a problem hiding this comment.
We need a clean environment between test runs, I couldn't find a way to run the nginx container with a directory that's created on runtime. Maybe someone from @elastic/es-delivery can help us with that?
There was a problem hiding this comment.
We can delete the directory contents in preprocessfixture task if necessary. We definitely don't want to do this during configuration time.
| setting 'xpack.searchable.snapshot.shared_cache.region_size', '256KB' | ||
| } | ||
|
|
||
| tasks.register("urlThirdPartyTest") { |
There was a problem hiding this comment.
This isn't a third-party test (it's running locally on the same machine) so why have this task?
There was a problem hiding this comment.
Yes, that was a mistake.
|
@elasticmachine run elasticsearch-ci/eql-correctness |
|
@elasticmachine update branch |
This commit also increases the max number of pooled HTTP connections