Update API: Add support for scripted upserts. #7144
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of inserts the UpdateHelper class will now allow the script used to apply updates to run on the upsert doc provided by clients. This allows the logic for managing the internal state of the data item to be managed by the script and is not reliant on clients performing the initialisation of data structures managed by the script.
| //Allow the script to abort the create by setting "op" to "none" | ||
| String scriptOpChoice = (String) ctx.get("op"); | ||
| if (scriptOpChoice != null) { | ||
| if ("none".equals(scriptOpChoice)) { |
There was a problem hiding this comment.
Maybe these if statements can be combined? Something like this:
if (!"create".equals(scriptOpChoice)) {
if ("none".equals(scriptOpChoice)) {
logger.warn("Used upsert operation [{}] for script [{}], doing nothing...", scriptOpChoice, request.script);
}
UpdateResponse update = new UpdateResponse(getResult.getIndex(), getResult.getType(), getResult.getId(),
getResult.getVersion(), false);
update.setGetResult(getResult);
return new Result(update, Operation.NONE, upsertDoc, XContentType.JSON);
}There was a problem hiding this comment.
Thanks, Martijn. Looks good but the log msg should only be output if not none i.e.
if (!"none".equals(scriptOpChoice)) {
logger.warn("Used upsert operation [{}] for script [{}], doing nothing...", scriptOpChoice, request.script);
}
|
@markharwood LGTM |
| [source,js] | ||
| -------------------------------------------------- | ||
| curl -XPOST 'localhost:9200/sessions/session/dh3sgudg8gsrgl/_update' -d '{ | ||
| "script_id" : "myWebSessionSummariser", |
There was a problem hiding this comment.
use underscore_case for consistency with the rest of the docs?
|
Will go ahead and push if no objections |
|
LGTM |
|
Committed in e6b459c |
clintongormley
added
v1.4.0.Beta1
v2.0.0-beta1
release highlight
>feature
and removed
>enhancement
labels
clintongormley
changed the title
| return this.scriptedUpsert; | ||
| } | ||
|
|
||
| public void scriptedUpsert(boolean scriptedUpsert) { |
clintongormley
added
the
:Distributed Indexing/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of inserts the UpdateHelper class will now allow the script used to apply updates to run on the upsert doc provided by clients. This allows the logic for managing the internal state of the data item to be managed by the script and is not reliant on clients performing the initialisation of data structures managed by the script.
Associated issue: #7143