Fix rest validation of search request using a PIT #71688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rest validation of the search request ensures that the indices options are set to the default value. However, the comparison is too strict and should use equals since we create a new IndicesOption object when parsing from http or transport. Closes elastic#69974
jimczi
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
dnhatn
approved these changes
Apr 14, 2021
server/src/main/java/org/elasticsearch/action/search/MultiSearchRequest.java
Outdated
Show resolved
Hide resolved
jimczi
added a commit
that referenced
this pull request
Apr 20, 2021
The rest validation of the search request ensures that the indices options are set to the default value. However, the comparison is too strict and should use equals since we create a new IndicesOption object when parsing from http or transport. Closes #69974
jimczi
added a commit
that referenced
this pull request
Apr 20, 2021
The rest validation of the search request ensures that the indices options are set to the default value. However, the comparison is too strict and should use equals since we create a new IndicesOption object when parsing from http or transport. Closes #69974
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Apr 21, 2021
Adjust this random test now that default indices options are not exposed in rest. Relates elastic#71688 Closes elastic#71916
jimczi
added a commit
that referenced
this pull request
Apr 22, 2021
jimczi
added a commit
that referenced
this pull request
Apr 22, 2021
jimczi
added a commit
that referenced
this pull request
Apr 28, 2021
jimczi
added a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest validation of the search request ensures that the indices options
are set to the default value. However, the comparison is too strict and should
use equals since we create a new IndicesOption object when parsing from http or transport.
Closes #69974