Prevent RestoreService from Triggering Redundant CS Updates (#71812) #71820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…71812) We shouldn't be triggering multiple of these cleanup updates. Worst case, if we have a long loop of CS updates (e.g. immediate tasks), this will create endless tasks. Furtunately this has been a problem in the real world so far because restore completion would have to coincide with a storm of tasks but should still be fixed.
original-brownbear
added
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be triggering multiple of these cleanup updates. Worst case, if we have
a long loop of CS updates (e.g. immediate tasks), this will create endless tasks.
Fortunately, this has been a problem in the real world so far because restore completion
would have to coincide with a storm of tasks but should still be fixed.
backport of #71812