Rename string_field script context to keyword_field #71854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now, the name of the script contexts that runtime fields use was internal only. They recently got exposed through the painless execute API. This commit fixes the discrepancy between the field type used to define a runtime field of type keyword and the script context needed to simulate its corresponding script: string_field should be keyword_field.
javanna
added
>enhancement
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
nik9000
approved these changes
Apr 19, 2021
jdconrad
approved these changes
Apr 19, 2021
|
the rest-compat tests here are expected to fail, because the tests from 7.x use string_field that we are renaming to keyword_field in master with this change. This is ok though because painless execute does not support the runtime fields context in any public release, so we are ok breaking this between 7.x and master. |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Apr 20, 2021
The script context is being renamed as part of elastic#71854, which is not a breaking change as we have not released a public version that supports such new context in the painless execute API. We will re-enable these tests once the linked PR is merged.
javanna
added a commit
that referenced
this pull request
Apr 20, 2021
The script context is being renamed as part of #71854, which is not a breaking change as we have not released a public version that supports such new context in the painless execute API. We will re-enable these tests once the linked PR is merged.
|
run elasticsearch-ci/rest-compat |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Apr 20, 2021
Up until now, the name of the script contexts that runtime fields use was internal only. They recently got exposed through the painless execute API. This commit fixes the discrepancy between the field type used to define a runtime field of type keyword and the script context needed to simulate its corresponding script: string_field should be keyword_field.
javanna
added a commit
that referenced
this pull request
Apr 21, 2021
Up until now, the name of the script contexts that runtime fields use was internal only. They recently got exposed through the painless execute API. This commit fixes the discrepancy between the field type used to define a runtime field of type keyword and the script context needed to simulate its corresponding script: string_field should be keyword_field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, the name of the script contexts that runtime fields use was internal only. They recently got exposed through the painless execute API. This commit fixes the discrepancy between the field type used to define a runtime field of type keyword and the script context needed to simulate its corresponding script: string_field should be keyword_field.