Add index-time scripts to geo_point field mapper #71861
Conversation
romseygeek
added
>feature
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
| }); | ||
| if (hasScript) { | ||
| throw new MapperParsingException("failed to parse field [" + fieldType().name() + "] of type + " + contentType() + "]", | ||
| new IllegalArgumentException("Cannot index data directly into a field with a [script] parameter")); |
There was a problem hiding this comment.
grr I forgot about the mappers that override parse when I added this to the base class. Is it worth extracting the check to a common method so that it can be called from here?
There was a problem hiding this comment.
I want to rework parse/parseCreateField anyway, as it's very confusing that we have these two methods with the same signature that do almost exactly the same thing. Can we consider this a band-aid until we tidy up in a followup?
There was a problem hiding this comment.
sure, anyways the test is unified and tests the error message, so we ensure that it is always the same one
| return new GeoPointFieldMapper(name, ft, multiFieldsBuilder.build(this, contentPath), | ||
| copyTo.build(), geoParser, this); | ||
| } | ||
| return new GeoPointFieldMapper(name, ft, geoParser, this); |
There was a problem hiding this comment.
is it necessary to use two different constructors with or without the script?
There was a problem hiding this comment.
The class hierarchy of the geo mappers makes things complicated here, but I can change this so that there's just a single constructor at the expense of adding extra params to all the other class constructors if you think it's less confusing.
There was a problem hiding this comment.
I don't have a strong opinion and I cannot judge if it makes things better. Your call ;)
I knew I'd forgotten something in the initial commit :). Thanks for the reviews! |
This commit adds the ability to define an index-time geo_point field with a script parameter, allowing you to calculate points from other values within the indexed document.
This commit adds the ability to define an index-time geo_point field
with a
scriptparameter, allowing you to calculate points from othervalues within the indexed document.