Add force single data path option for integ tests #71868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some functionality will no longer work with multiple data paths and in order to run integration tests for that, we need the capability to force a single data path for those tests. Relates elastic#71844
henningandersen
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
henningandersen
added
:Delivery/Build
elasticmachine
added
Team:Delivery
|
Pinging @elastic/es-delivery (Team:Delivery) |
jasontedor
approved these changes
Apr 20, 2021
| @@ -350,7 +352,7 @@ public InternalTestCluster( | |||
| numSharedDedicatedMasterNodes, numSharedDataNodes, numSharedCoordOnlyNodes, | |||
| autoManageMasterNodes ? "auto-managed" : "manual"); | |||
| this.nodeConfigurationSource = nodeConfigurationSource; | |||
| numDataPaths = random.nextInt(5) == 0 ? 2 + random.nextInt(3) : 1; | |||
| numDataPaths = forceSingleDataPath == false && random.nextInt(5) == 0 ? 2 + random.nextInt(3) : 1; | |||
There was a problem hiding this comment.
Could we rewrite this slightly so it’s clearer: I would want it to read “if forceSingleDataPath is true then 1 else some random number of data paths” instead of the double negation right now. How about
// use 1 data path if we are forced to, or 80% of the time that we are not, otherwise use between 2 and 4 data paths
numDataPaths = forceSingleDataPath || random.nextInt(5) != 0 ? 1 : 2 + random.nextInt(3);And maybe that random.nextInt(5) !=0 should be random.nextDouble() < 0.8 and then it’s even clearer?
// use 1 data path if we are forced to, or 80% of the time that we are not, otherwise use between 2 and 4 data paths
numDataPaths = forceSingleDataPath || random.nextDouble() < 0.8 ? 1 : 2 + random.nextInt(3);And for one more iteration on clarity, how about randomIntBetween(2, 4)?
// use 1 data path if we are forced to, or 80% of the time that we are not, otherwise use between 2 and 4 data paths
numDataPaths = forceSingleDataPath || random.nextDouble() < 0.8 ? 1 : randomIntBetween(2, 4);
|
@elasticmachine update branch |
henningandersen
added a commit
that referenced
this pull request
Apr 20, 2021
Some functionality will no longer work with multiple data paths and in order to run integration tests for that, we need the capability to force a single data path for those tests. Relates #71844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functionality will no longer work with multiple data paths and in
order to run integration tests for that, we need the capability to
force a single data path for those tests.
Relates #71844
Opt'ed for a method on
ESIntegTestCaseover adding to the annotation, since this felt less intrusive and MDP is going away anyway.