-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Update joda dependency to latest 2.10.10 #72052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Latest JDKs are shipping with timezone data 2021a which is also included in latest joda. In order to have the timezone information consistent in both joda and java.time joda dependnecy has to be updated closes elastic#72028
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -15,4 +15,4 @@ systemProp.jdk.tls.client.protocols=TLSv1.2 | |||
|
|||
# java homes resolved by environment variables | |||
org.gradle.java.installations.auto-detect=false | |||
org.gradle.java.installations.fromEnv=JAVA_HOME,RUNTIME_JAVA_HOME,JAVA16_HOME,JAVA15_HOME,JAVA14_HOME,JAVA13_HOME,JAVA12_HOME,JAVA11_HOME,JAVA8_HOME | |||
org.gradle.java.installations.fromEnv=JAVA_HOME,RUNTIME_JAVA_HOME,JAVA17_HOME,JAVA16_HOME,JAVA15_HOME,JAVA14_HOME,JAVA13_HOME,JAVA12_HOME,JAVA11_HOME,JAVA8_HOME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mark-vieira For the future, should this be taken care of when adding testing/CI for new Java versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually only needed for building BWC versions, of which none require JAVA17 at the moment.
waiting for latest updates of jdk be available https://github.com/elastic/infra/pull/28512/files |
…into joda/update_joda
@mark-vieira @rjernst in order to use latest updates in jdk we would have to use adoptopenjdk. Do you remember why we went with testing against openjdk so far? |
@elasticmachine update branch |
Latest JDKs are shipping with timezone data 2021a which is also included in latest joda. In order to have the timezone information consistent in both joda and java.time joda dependnecy has to be updated closes elastic#72028
Latest JDKs are shipping with timezone data 2021a which is also included in latest joda. In order to have the timezone information consistent in both joda and java.time joda dependnecy has to be updated closes elastic#72028
Latest JDKs are shipping with timezone data 2021a which is also included in latest joda. In order to have the timezone information consistent in both joda and java.time joda dependnecy has to be updated closes elastic#72028
Latest JDKs are shipping with timezone data 2021a which is also included
in latest joda. In order to have the timezone information consistent in
both joda and java.time joda dependnecy has to be updated
closes #72028
gradle check
?