Skip to content

Update joda dependency to latest 2.10.10 #72052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 29, 2021

Conversation

pgomulka
Copy link
Contributor

Latest JDKs are shipping with timezone data 2021a which is also included
in latest joda. In order to have the timezone information consistent in
both joda and java.time joda dependnecy has to be updated

closes #72028

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

Latest JDKs are shipping with timezone data 2021a which is also included
in latest joda. In order to have the timezone information consistent in
both joda and java.time joda dependnecy has to be updated

closes elastic#72028
@pgomulka pgomulka self-assigned this Apr 21, 2021
@pgomulka pgomulka added the :Core/Infra/Core Core issues without another label label Apr 21, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Apr 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -15,4 +15,4 @@ systemProp.jdk.tls.client.protocols=TLSv1.2

# java homes resolved by environment variables
org.gradle.java.installations.auto-detect=false
org.gradle.java.installations.fromEnv=JAVA_HOME,RUNTIME_JAVA_HOME,JAVA16_HOME,JAVA15_HOME,JAVA14_HOME,JAVA13_HOME,JAVA12_HOME,JAVA11_HOME,JAVA8_HOME
org.gradle.java.installations.fromEnv=JAVA_HOME,RUNTIME_JAVA_HOME,JAVA17_HOME,JAVA16_HOME,JAVA15_HOME,JAVA14_HOME,JAVA13_HOME,JAVA12_HOME,JAVA11_HOME,JAVA8_HOME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-vieira For the future, should this be taken care of when adding testing/CI for new Java versions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually only needed for building BWC versions, of which none require JAVA17 at the moment.

@pgomulka
Copy link
Contributor Author

waiting for latest updates of jdk be available https://github.com/elastic/infra/pull/28512/files

@pgomulka
Copy link
Contributor Author

@mark-vieira @rjernst in order to use latest updates in jdk we would have to use adoptopenjdk. Do you remember why we went with testing against openjdk so far?

@pgomulka
Copy link
Contributor Author

@elasticmachine update branch

@pgomulka pgomulka merged commit b0a0d56 into elastic:master Apr 29, 2021
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Apr 29, 2021
Latest JDKs are shipping with timezone data 2021a which is also included
in latest joda. In order to have the timezone information consistent in
both joda and java.time joda dependnecy has to be updated

closes elastic#72028
pgomulka added a commit that referenced this pull request Apr 29, 2021
Latest JDKs are shipping with timezone data 2021a which is also included
in latest joda. In order to have the timezone information consistent in
both joda and java.time joda dependnecy has to be updated

closes #72028
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Apr 29, 2021
Latest JDKs are shipping with timezone data 2021a which is also included
in latest joda. In order to have the timezone information consistent in
both joda and java.time joda dependnecy has to be updated

closes elastic#72028
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Apr 29, 2021
Latest JDKs are shipping with timezone data 2021a which is also included
in latest joda. In order to have the timezone information consistent in
both joda and java.time joda dependnecy has to be updated

closes elastic#72028
pgomulka added a commit that referenced this pull request Apr 29, 2021
Latest JDKs are shipping with timezone data 2021a which is also included
in latest joda. In order to have the timezone information consistent in
both joda and java.time joda dependnecy has to be updated

closes #72028
pgomulka added a commit that referenced this pull request May 10, 2021
Latest JDKs are shipping with timezone data 2021a which is also included
in latest joda. In order to have the timezone information consistent in
both joda and java.time joda dependnecy has to be updated

closes #72028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v6.8.16 v7.13.0 v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] DateUtilsTests testTimezoneIds failing
5 participants