-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Convert MavenFilteringHack, Groovy to Java #72058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/es-delivery (Team:Delivery) |
@elasticsearchmachine test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
thanks for your contribution. There's a minor issue with your changes that breaks the build when passing non String values to the MavenFilteringHack
.
If you are able to fix this we can merge this PR
buildSrc/src/main/java/org/elasticsearch/gradle/MavenFilteringHack.java
Outdated
Show resolved
Hide resolved
@elasticmachine test this please |
@elasticmachine test this please |
@edh-oss I've merged your PR. Thanks again for your contribution! |
Port to Java, related to issue #34459