Store index creation time in index metadata #7218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although my comment is not directly related to the PR, I think that if we can also support
Related to #3933 |
| @@ -363,6 +363,8 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws | |||
|
|
|||
| builder.field("state", indexMetaData.state().toString().toLowerCase(Locale.ENGLISH)); | |||
|
|
|||
| builder.field("creation_date", indexMetaData.creationDate()); | |||
There was a problem hiding this comment.
I think it should rather be part of the index meta data settings? (like the created version and the uuid?)
|
Left one comment but other than that it looks good to me. |
| @@ -556,6 +574,7 @@ public static void toXContent(IndexMetaData indexMetaData, XContentBuilder build | |||
| builder.startObject(indexMetaData.index(), XContentBuilder.FieldCaseConversion.NONE); | |||
|
|
|||
| builder.field("version", indexMetaData.version()); | |||
| builder.field("creation_date", indexMetaData.creationDate()); | |||
There was a problem hiding this comment.
I don't think it is needed, it will be serialized as part of the settings?
This change stores the index creation time in the index metadata when an index is created. The creation time cannot be changed but can be set as part of the create index request to allow for correct creation times for historical data. Closes #7119
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change stores the index creation time in the index metadata when an index is created. The creation time cannot be changed but can be set as part of the create index request to allow for correct creation times for historical data.
Closes #7119