Allow more digits in the year part of dates #72190
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
external-contributor
misterbyrne
commented
Apr 24, 2021
|
|
||
| assertSameDate("2018-12-31T10:15:30", "date_optional_time"); | ||
| assertSameDate("12018-12-31T10:15:30", "date_optional_time"); | ||
| assertSameDate("122018-12-31T10:15:30", "date_optional_time"); |
There was a problem hiding this comment.
The tests fail here without any code changes - output:
2> java.lang.IllegalArgumentException: failed to parse date field [122018-12-31T10:15:30] with format [date_optional_time]
at __randomizedtesting.SeedInfo.seed([3F1FADBA0ED58CED:34814355688917EA]:0)
at org.elasticsearch.common.time.JavaDateFormatter.parse(JavaDateFormatter.java:170)
at org.elasticsearch.common.joda.JavaJodaTimeDuellingTests.assertSameDate(JavaJodaTimeDuellingTests.java:887)
at org.elasticsearch.common.joda.JavaJodaTimeDuellingTests.assertSameDate(JavaJodaTimeDuellingTests.java:875)
at org.elasticsearch.common.joda.JavaJodaTimeDuellingTests.testDateOptionalTimeYearsWithManyDigits(JavaJodaTimeDuellingTests.java:228)
Caused by:
java.time.format.DateTimeParseException: Text '122018-12-31T10:15:30' could not be parsed, unparsed text found at index 5
at java.base/java.time.format.DateTimeFormatter.parseResolved0(DateTimeFormatter.java:2055)
at java.base/java.time.format.DateTimeFormatter.parse(DateTimeFormatter.java:1880)
at org.elasticsearch.common.time.JavaDateFormatter.doParse(JavaDateFormatter.java:199)
at org.elasticsearch.common.time.JavaDateFormatter.parse(JavaDateFormatter.java:168)
... 3 more
imotov
added
the
:Search Foundations/Mapping
|
@misterbyrne since this PR is mostly to demonstrate the problem and the original issue is assigned, I hope you don't mind me closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #72191
This mostly serves to illustrate the issue and the root cause :)