Allow disabling ignore_malformed on data stream's timestamp field #72406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `index.mapping.ignore_malformed` has been set to `true` then
here is no way to overwrite that to `false` for a data stream's
timestamp field.
Before this commit, validation would fail that disallow the usage
of `ignore_malformed` attribute on a data stream's timestamp field.
This commit allows the usage of `ignore_malformed` attribute,
so that `index.mapping.ignore_malformed` can be disabled for a
data stream's timestamp field. The `ignore_malformed` attribute
can only be set to false.
This allows the following index template:
```
PUT /_index_template/filebeat
{
"index_patterns": [
"filebeat-*"
],
"template": {
"settings": {
"index": {
"mapping.ignore_malformed": true
}
},
"mappings": {
"properties": {
"@timestamp": {
"type": "date",
"ignore_malformed": false
}
}
}
},
"data_stream": {}
}
```
Closes elastic#71755
martijnvg
added
>bug
v8.0.0
:Data Management/Data streams
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
danhermann
approved these changes
Apr 28, 2021
Yes and that is tested in the second half of the test: https://github.com/elastic/elasticsearch/pull/72406/files#diff-0de2e45646b4c7099f9eac6435368bc8bcc22c37dc2c841c4603cb3113bf23dbR167 |
Ah, thanks, I missed that. |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Apr 29, 2021
Backporting elastic#72406 to 7.x branch. If `index.mapping.ignore_malformed` has been set to `true` then here is no way to overwrite that to `false` for a data stream's timestamp field. Before this commit, validation would fail that disallow the usage of `ignore_malformed` attribute on a data stream's timestamp field. This commit allows the usage of `ignore_malformed` attribute, so that `index.mapping.ignore_malformed` can be disabled for a data stream's timestamp field. The `ignore_malformed` attribute can only be set to false. This allows the following index template: ``` PUT /_index_template/filebeat { "index_patterns": [ "filebeat-*" ], "template": { "settings": { "index": { "mapping.ignore_malformed": true } }, "mappings": { "properties": { "@timestamp": { "type": "date", "ignore_malformed": false } } } }, "data_stream": {} } ``` Closes elastic#71755
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Apr 29, 2021
Backporting elastic#72406 to 7.13 branch. If `index.mapping.ignore_malformed` has been set to `true` then here is no way to overwrite that to `false` for a data stream's timestamp field. Before this commit, validation would fail that disallow the usage of `ignore_malformed` attribute on a data stream's timestamp field. This commit allows the usage of `ignore_malformed` attribute, so that `index.mapping.ignore_malformed` can be disabled for a data stream's timestamp field. The `ignore_malformed` attribute can only be set to false. This allows the following index template: ``` PUT /_index_template/filebeat { "index_patterns": [ "filebeat-*" ], "template": { "settings": { "index": { "mapping.ignore_malformed": true } }, "mappings": { "properties": { "@timestamp": { "type": "date", "ignore_malformed": false } } } }, "data_stream": {} } ``` Closes elastic#71755
martijnvg
added a commit
that referenced
this pull request
Apr 29, 2021
…2446) Backporting #72406 to 7.13 branch. If `index.mapping.ignore_malformed` has been set to `true` then here is no way to overwrite that to `false` for a data stream's timestamp field. Before this commit, validation would fail that disallow the usage of `ignore_malformed` attribute on a data stream's timestamp field. This commit allows the usage of `ignore_malformed` attribute, so that `index.mapping.ignore_malformed` can be disabled for a data stream's timestamp field. The `ignore_malformed` attribute can only be set to false. This allows the following index template: ``` PUT /_index_template/filebeat { "index_patterns": [ "filebeat-*" ], "template": { "settings": { "index": { "mapping.ignore_malformed": true } }, "mappings": { "properties": { "@timestamp": { "type": "date", "ignore_malformed": false } } } }, "data_stream": {} } ``` Closes #71755
martijnvg
added a commit
that referenced
this pull request
Apr 29, 2021
…2444) Backporting #72406 to 7.x branch. If `index.mapping.ignore_malformed` has been set to `true` then here is no way to overwrite that to `false` for a data stream's timestamp field. Before this commit, validation would fail that disallow the usage of `ignore_malformed` attribute on a data stream's timestamp field. This commit allows the usage of `ignore_malformed` attribute, so that `index.mapping.ignore_malformed` can be disabled for a data stream's timestamp field. The `ignore_malformed` attribute can only be set to false. This allows the following index template: ``` PUT /_index_template/filebeat { "index_patterns": [ "filebeat-*" ], "template": { "settings": { "index": { "mapping.ignore_malformed": true } }, "mappings": { "properties": { "@timestamp": { "type": "date", "ignore_malformed": false } } } }, "data_stream": {} } ``` Closes #71755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
index.mapping.ignore_malformedhas been set totruethenhere is no way to overwrite that to
falsefor a data stream'stimestamp field.
Before this commit, validation would fail that disallow the usage
of
ignore_malformedattribute on a data stream's timestamp field.This commit allows the usage of
ignore_malformedattribute,so that
index.mapping.ignore_malformedcan be disabled for adata stream's timestamp field. The
ignore_malformedattributecan only be set to false.
This allows the following index template:
Closes #71755