Skip to content

[7.x][ML] Prevent data frame analytics freeze after loading data (#72412) #72449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,6 @@ public void testWithOnlyTrainingRowsAndTrainingPercentIsFifty_DependentVariableI
"classification_training_percent_is_50_boolean", BOOLEAN_FIELD, BOOLEAN_FIELD_VALUES, "boolean");
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/67581")
public void testStopAndRestart() throws Exception {
initialize("classification_stop_and_restart");
String predictedClassField = KEYWORD_FIELD + "_prediction";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public abstract class AbstractControlMsgWriter {
/**
* This should be the same size as the buffer in the C++ native process.
*/
public static final int FLUSH_SPACES_LENGTH = 8192;
public static final int FLUSH_SPACES_LENGTH = 2048;

protected final LengthEncodedWriter lengthEncodedWriter;
private final int numberOfFields;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public void testWriteEndOfData() throws IOException {
inOrder.verify(lengthEncodedWriter).writeField("$");

StringBuilder spaces = new StringBuilder();
IntStream.rangeClosed(1, 8192).forEach(i -> spaces.append(' '));
IntStream.rangeClosed(1, 2048).forEach(i -> spaces.append(' '));
inOrder.verify(lengthEncodedWriter).writeNumFields(4);
inOrder.verify(lengthEncodedWriter, times(3)).writeField("");
inOrder.verify(lengthEncodedWriter).writeField(spaces.toString());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ public void testWriteFlushMessage() throws IOException {
inOrder.verify(lengthEncodedWriter).writeNumFields(4);
inOrder.verify(lengthEncodedWriter, times(3)).writeField("");
StringBuilder spaces = new StringBuilder();
IntStream.rangeClosed(1, 8192).forEach(i -> spaces.append(' '));
IntStream.rangeClosed(1, 2048).forEach(i -> spaces.append(' '));
inOrder.verify(lengthEncodedWriter).writeField(spaces.toString());

inOrder.verify(lengthEncodedWriter).flush();
Expand Down