Add a cluster deprecation check for index templates containing multiple types #72540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>enhancement
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
alisonelizabeth
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Thanks for adding this deprecation @romseygeek! The deprecation message LGTM as well as implementation from a high level. I'll defer to an ES engineer if you'd like a more thorough code review.
|
Thanks @alisonelizabeth, I've pinged @jtibshirani to get an ES view on it. |
jtibshirani
approved these changes
Apr 30, 2021
| if (templatesWithMultipleTypes.isEmpty()) { | ||
| return null; | ||
| } | ||
| return new DeprecationIssue(DeprecationIssue.Level.CRITICAL, |
There was a problem hiding this comment.
Just for my knowledge, does CRITICAL mean we'll prevent the upgrade from proceeding?
There was a problem hiding this comment.
Good question, I've asked in the core-features channel and will try to find out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an index template that creates multiple mapping types will already
throw an error in 7.x. This upgrade check should help filter out any unused
templates with multiple types that are still lurking in the cluster state.