Fix Edge Case Datastream Snapshot Create Bug #72747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always clean up the list of datastreams depending on the indices acutally in the snapshot. Even for non-partial snapshots datastream indices could be excluded from the snapshot by index exlusions that remove all the datastream's indices from the snapshot.
original-brownbear
added
>bug
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
|
Pinging @elastic/es-distributed (Team:Distributed) |
danhermann
approved these changes
May 5, 2021
There was a problem hiding this comment.
This LGTM. Thanks for addressing it, @original-brownbear!
Tangentially related, but I wonder if we should document that snapshots of data streams can include a subset of their current backing indices and upon restore can have a different write index. If so, I can open a PR for that.
|
Thanks Dan! and ++ on documenting this better. |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 5, 2021
We always clean up the list of datastreams depending on the indices acutally in the snapshot. Even for non-partial snapshots datastream indices could be excluded from the snapshot by index exlusions that remove all the datastream's indices from the snapshot.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 5, 2021
We always clean up the list of datastreams depending on the indices acutally in the snapshot. Even for non-partial snapshots datastream indices could be excluded from the snapshot by index exlusions that remove all the datastream's indices from the snapshot.
original-brownbear
added a commit
that referenced
this pull request
May 5, 2021
We always clean up the list of datastreams depending on the indices acutally in the snapshot. Even for non-partial snapshots datastream indices could be excluded from the snapshot by index exlusions that remove all the datastream's indices from the snapshot.
original-brownbear
added a commit
that referenced
this pull request
May 5, 2021
We always clean up the list of datastreams depending on the indices acutally in the snapshot. Even for non-partial snapshots datastream indices could be excluded from the snapshot by index exlusions that remove all the datastream's indices from the snapshot.
|
See #72761 |
This was referenced Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always clean up the list of datastreams depending on the indices actually
in the snapshot. Even for non-partial snapshots datastream indices could be
excluded from the snapshot by index exclusions that remove all the datastream's
indices from the snapshot.