Skip to content

[Rest Api Compatibility] REST Terms vector typed response #73117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2021

Conversation

pgomulka
Copy link
Contributor

enabeling the tests and adds a type field for termvector response
the commit that enabled typed enpoints but missed to update the response
#72155

pgomulka added 2 commits May 14, 2021 19:01
…tDeleteAction

the previously removed typed enpotins for Update and Delete are
retrofitted in this commit
the commit that removed them
elastic#47671

relates main meta issue elastic#51816
relates types removal issue elastic#54160
enabeling the tests and adds a type field for termvector response
the commit that enabled typed enpoints but missed to update the response
elastic#72155
@pgomulka pgomulka added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 labels May 14, 2021
@pgomulka pgomulka self-assigned this May 14, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label May 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@romseygeek
Copy link
Contributor

This looks like it also includes the changes from #73115?

@pgomulka
Copy link
Contributor Author

yes, forgot about this. I did this to prevent any merge conflicts. I was planning to merge #73115 then update this PR and merge it later.
The PRs ended up without much conflicts - except from the obvious build.gradle - so probably this was unnecessary.
Would it be ok if you review #73115 first? I will then ping you again once I update this PR

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants