Skip to content

Fix typo in Rectangle() error message #73124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2021
Merged

Fix typo in Rectangle() error message #73124

merged 3 commits into from
May 18, 2021

Conversation

mhogeweg
Copy link
Contributor

line 73 said: 'max y cannot be less than min x', while this should be 'min y'

@mhogeweg
fix typo in Rectangle() error message
7d64e53 
line 73 said: 'max y cannot be less than min x', while this should be 'min y'
@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label May 14, 2021
@jrodewig jrodewig added v7.14.0 v8.0.0 :Analytics/Geo Indexing, search aggregations of geo points and shapes labels May 18, 2021
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

jrodewig
jrodewig approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll defer to @imotov for final approval.

@jrodewig jrodewig requested a review from imotov May 18, 2021 12:33
@jrodewig
Copy link
Contributor

@elasticmachine ok to test

@jrodewig
Copy link
Contributor

@elasticmachine update branch

@jrodewig jrodewig changed the title fix typo in Rectangle() error message Fix typo in Rectangle() error message May 18, 2021
@imotov
Copy link
Contributor

imotov commented May 18, 2021

@elasticmachine test this please

imotov
imotov approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM.

@jrodewig jrodewig merged commit 8e46acf into elastic:master May 18, 2021
@jrodewig jrodewig mentioned this pull request May 18, 2021
Merged
@jrodewig jrodewig mentioned this pull request May 18, 2021
Merged
jrodewig added a commit that referenced this pull request May 18, 2021
@jrodewig @mhogeweg
Fix typo in Rectangle() error message (#73124) (#73212)
018ac3b 
Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: Marten <[email protected]>
jrodewig added a commit that referenced this pull request May 18, 2021
@jrodewig @mhogeweg
Fix typo in Rectangle() error message (#73124) (#73211)
00e8789 
Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: Marten <[email protected]>
@jrodewig jrodewig added the >bug label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imotov imotov imotov approved these changes

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.13.1 v7.14.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mhogeweg @elasticmachine @jrodewig @imotov @jakelandis @elasticsearchmachine