Improve BlobStoreFormatTests#randomCorruption #73201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method today corrupts bytes until the checksum changes, but (a) it's comparing the checksum vs one computed before even reading the file, and (b) changing a single byte will always invalidate a CRC-32 checksum so the loop is unnecessary as is the checksum calculation. It also doesn't ever try truncating the file which is a realistic kind of corruption that we must be able to detect. This commit addresses all that.
DaveCTurner
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
requested review from
original-brownbear and
tlrx
and removed request for
original-brownbear
…obStoreFormatTests-randomCorruption
DaveCTurner
deleted the
2021-05-18-fix-BlobStoreFormatTests-randomCorruption
branch
DaveCTurner
added a commit
that referenced
this pull request
May 18, 2021
This method today corrupts bytes until the checksum changes, but (a) it's comparing the checksum vs one computed before even reading the file, and (b) changing a single byte will always invalidate a CRC-32 checksum so the loop is unnecessary as is the checksum calculation. It also doesn't ever try truncating the file which is a realistic kind of corruption that we must be able to detect. This commit addresses all that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method today corrupts bytes until the checksum changes, but (a)
it's comparing the checksum vs one computed before even reading the
file, and (b) changing a single byte will always invalidate a CRC-32
checksum so the loop is unnecessary as is the checksum calculation. It
also doesn't ever try truncating the file which is a realistic kind of
corruption that we must be able to detect.
This commit addresses all that.