[ML] fix empty body on post issue for datafeed _preview #73205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
@elasticmachine update branch |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
May 18, 2021
It is common practice to pass an empty body on a `POST` call. Consequently, a `POST _ml/datafeed/<ID>/_preview` could fail if the body is empty as we try to parse it while IGNORING the ID in the URL. This commit fixes that bug. closes elastic#73206
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
May 18, 2021
It is common practice to pass an empty body on a `POST` call. Consequently, a `POST _ml/datafeed/<ID>/_preview` could fail if the body is empty as we try to parse it while IGNORING the ID in the URL. This commit fixes that bug. closes elastic#73206
benwtrent
added a commit
that referenced
this pull request
May 18, 2021
) It is common practice to pass an empty body on a `POST` call. Consequently, a `POST _ml/datafeed/<ID>/_preview` could fail if the body is empty as we try to parse it while IGNORING the ID in the URL. This commit fixes that bug. closes #73206
benwtrent
added a commit
that referenced
this pull request
May 18, 2021
) It is common practice to pass an empty body on a `POST` call. Consequently, a `POST _ml/datafeed/<ID>/_preview` could fail if the body is empty as we try to parse it while IGNORING the ID in the URL. This commit fixes that bug. closes #73206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common practice to pass an empty body on a
POSTcall. Consequently, aPOST _ml/datafeed/<ID>/_previewcould fail if the body is empty as we try to parse it while IGNORING the ID in the URL.This commit fixes that bug.
closes #73206