Skip to content

Add keep_values gap policy #73297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 8, 2021

Conversation

imotov
Copy link
Contributor

@imotov imotov commented May 20, 2021

Adds a new keep_values gap policy that works like skip, except if the metric
calculated on an empty bucket provides a non-null non-NaN value, this value is
used for the bucket.

Fixes #27377

Adds a new keep_values gap policy that works like skip, except if the metric
calculated on an empty bucket provides a non-null non-NaN value, this value is
used for the bucket.

Fixes elastic#27377
@imotov
Copy link
Contributor Author

imotov commented Jun 1, 2021

@elasticmachine update branch

@imotov
Copy link
Contributor Author

imotov commented Jun 1, 2021

@elasticmachine run elasticsearch-ci/part-1

@imotov
Copy link
Contributor Author

imotov commented Jun 1, 2021

@elasticmachine run elasticsearch-ci/bwc

@imotov
Copy link
Contributor Author

imotov commented Jun 1, 2021

@elasticmachine update branch

@imotov
Copy link
Contributor Author

imotov commented Jun 1, 2021

@elasticmachine update branch

@imotov
Copy link
Contributor Author

imotov commented Jun 2, 2021

@elasticmachine update branch

@imotov
Copy link
Contributor Author

imotov commented Jun 3, 2021

@elasticmachine update branch

@imotov imotov requested a review from not-napoleon June 3, 2021 17:36
@imotov imotov marked this pull request as ready for review June 3, 2021 17:38
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@imotov imotov removed the WIP label Jun 3, 2021
Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@imotov
Copy link
Contributor Author

imotov commented Jun 8, 2021

@elasticmachine update branch

@imotov
Copy link
Contributor Author

imotov commented Jun 8, 2021

@elasticmachine run elasticsearch-ci/bwc

@imotov imotov merged commit db36b6c into elastic:master Jun 8, 2021
imotov added a commit that referenced this pull request Jun 8, 2021
Adds a new keep_values gap policy that works like skip, except if the metric
calculated on an empty bucket provides a non-null non-NaN value, this value is
used for the bucket.

Fixes #27377

Co-authored-by: Mark Tozzi <[email protected]>
@imotov imotov deleted the issue-27377-bucket-agg-on-missing-docs branch June 8, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bucket script aggregation returns invalid value for missing docs
4 participants