Fix eclipse for build tools #73699

breskeby · 2021-06-02T20:49:26Z

This addresses #73615 and applies common eclipse config to all projects across the elasticsearch workspace including build tools projects

breskeby · 2021-06-02T20:51:18Z

@nik9000 I've noticed that when I import eclipse locally I still see many /bin folders due to the output classpath entry pointing to bin/default. This has always been the case and I wonder if this is not bothering you in your local setup as this configuration hasn't changed.

We could change the default output location to e.g. out/default to fix this but this would be a change in behaviour.

nik9000 · 2021-06-02T20:54:44Z

Before the bug this is fixing I don't remember hidden bin folders. I'll pull this locally and see what is up.

nik9000 · 2021-06-03T12:09:18Z

With this plugin most projects don't import into Eclipse properly and have an error like:

Failed to configure project build-tools	build.gradle	/elasticsearch	line 0	Gradle Error Marker
Java Model Exception: Java Model Status [Test source folder 'src/test/java' in project 'build-tools' must have an output folder that is not also used for main sources]
	at org.eclipse.jdt.internal.core.JavaModelOperation.runOperation(JavaModelOperation.java:802)
	at org.eclipse.jdt.internal.core.JavaProject.setRawClasspath(JavaProject.java:3650)
	at org.eclipse.jdt.internal.core.JavaProject.setRawClasspath(JavaProject.java:3610)
	at org.eclipse.jdt.internal.core.JavaProject.setRawClasspath(JavaProject.java:3666)
	at org.eclipse.buildship.core.internal.workspace.SourceFolderUpdater.updateSourceFolders(SourceFolderUpdater.java:71)
	at org.eclipse.buildship.core.internal.workspace.SourceFolderUpdater.update(SourceFolderUpdater.java:169)
	at org.eclipse.buildship.core.internal.workspace.BaseConfigurator.synchronizeJavaProjectInTransaction(BaseConfigurator.java:116)
	at org.eclipse.buildship.core.internal.workspace.BaseConfigurator.access$000(BaseConfigurator.java:40)
	at org.eclipse.buildship.core.internal.workspace.BaseConfigurator$1.run(BaseConfigurator.java:105)
	at org.eclipse.jdt.internal.core.BatchOperation.executeOperation(BatchOperation.java:41)
	at org.eclipse.jdt.internal.core.JavaModelOperation.run(JavaModelOperation.java:740)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2292)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2317)
	at org.eclipse.jdt.core.JavaCore.run(JavaCore.java:5901)
	at org.eclipse.jdt.core.JavaCore.run(JavaCore.java:5858)
	at org.eclipse.buildship.core.internal.workspace.BaseConfigurator.synchronizeJavaProject(BaseConfigurator.java:101)
	at org.eclipse.buildship.core.internal.workspace.BaseConfigurator.configure(BaseConfigurator.java:91)
	at org.eclipse.buildship.core.internal.workspace.BaseConfigurator.configure(BaseConfigurator.java:66)
	at org.eclipse.buildship.core.internal.extension.InternalProjectConfigurator.configure(InternalProjectConfigurator.java:65)
	at org.eclipse.buildship.core.internal.workspace.ProjectConfigurators.configureConfigurators(ProjectConfigurators.java:70)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation.synchronizeOpenWorkspaceProject(SynchronizeGradleBuildOperation.java:163)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation.synchronizeWorkspaceProject(SynchronizeGradleBuildOperation.java:137)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation.synchronizeGradleProjectWithWorkspaceProject(SynchronizeGradleBuildOperation.java:127)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation.access$000(SynchronizeGradleBuildOperation.java:42)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation$1.run(SynchronizeGradleBuildOperation.java:85)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2292)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2312)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation.synchronizeProjectsWithWorkspace(SynchronizeGradleBuildOperation.java:82)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation.run(SynchronizeGradleBuildOperation.java:64)
	at org.eclipse.buildship.core.internal.DefaultGradleBuild$SynchronizeOperation.runInToolingApi(DefaultGradleBuild.java:230)
	at org.eclipse.buildship.core.internal.operation.DefaultToolingApiOperationManager$WorkspaceRunnableAdapter.run(DefaultToolingApiOperationManager.java:58)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2292)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2317)
	at org.eclipse.buildship.core.internal.operation.DefaultToolingApiOperationManager.run(DefaultToolingApiOperationManager.java:39)
	at org.eclipse.buildship.core.internal.DefaultGradleBuild$SynchronizeOperation.run(DefaultGradleBuild.java:192)
	at org.eclipse.buildship.core.internal.DefaultGradleBuild.synchronize(DefaultGradleBuild.java:100)
	at org.eclipse.buildship.core.internal.workspace.SynchronizationJob.runInToolingApi(SynchronizationJob.java:64)
	at org.eclipse.buildship.core.internal.workspace.SynchronizationJob.runInToolingApi(SynchronizationJob.java:30)
	at org.eclipse.buildship.core.internal.operation.ToolingApiJob$1.runInToolingApi(ToolingApiJob.java:54)
	at org.eclipse.buildship.core.internal.operation.DefaultToolingApiOperationManager$WorkspaceRunnableAdapter.run(DefaultToolingApiOperationManager.java:58)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2292)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2317)
	at org.eclipse.buildship.core.internal.operation.DefaultToolingApiOperationManager.run(DefaultToolingApiOperationManager.java:39)
	at org.eclipse.buildship.core.internal.operation.ToolingApiJob.run(ToolingApiJob.java:65)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

Here's the one for the server:

Failed to configure project :server	build.gradle	/elasticsearch	line 0	Gradle Error Marker
Java Model Exception: Java Model Status [Test source folder 'src/test/java' in project ':server' must have an output folder that is not also used for main sources]
	at org.eclipse.jdt.internal.core.JavaModelOperation.runOperation(JavaModelOperation.java:802)
	at org.eclipse.jdt.internal.core.JavaProject.setRawClasspath(JavaProject.java:3650)
	at org.eclipse.jdt.internal.core.JavaProject.setRawClasspath(JavaProject.java:3610)
	at org.eclipse.jdt.internal.core.JavaProject.setRawClasspath(JavaProject.java:3666)
	at org.eclipse.buildship.core.internal.workspace.SourceFolderUpdater.updateSourceFolders(SourceFolderUpdater.java:71)
	at org.eclipse.buildship.core.internal.workspace.SourceFolderUpdater.update(SourceFolderUpdater.java:169)
	at org.eclipse.buildship.core.internal.workspace.BaseConfigurator.synchronizeJavaProjectInTransaction(BaseConfigurator.java:116)
	at org.eclipse.buildship.core.internal.workspace.BaseConfigurator.access$000(BaseConfigurator.java:40)
	at org.eclipse.buildship.core.internal.workspace.BaseConfigurator$1.run(BaseConfigurator.java:105)
	at org.eclipse.jdt.internal.core.BatchOperation.executeOperation(BatchOperation.java:41)
	at org.eclipse.jdt.internal.core.JavaModelOperation.run(JavaModelOperation.java:740)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2292)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2317)
	at org.eclipse.jdt.core.JavaCore.run(JavaCore.java:5901)
	at org.eclipse.jdt.core.JavaCore.run(JavaCore.java:5858)
	at org.eclipse.buildship.core.internal.workspace.BaseConfigurator.synchronizeJavaProject(BaseConfigurator.java:101)
	at org.eclipse.buildship.core.internal.workspace.BaseConfigurator.configure(BaseConfigurator.java:91)
	at org.eclipse.buildship.core.internal.workspace.BaseConfigurator.configure(BaseConfigurator.java:66)
	at org.eclipse.buildship.core.internal.extension.InternalProjectConfigurator.configure(InternalProjectConfigurator.java:65)
	at org.eclipse.buildship.core.internal.workspace.ProjectConfigurators.configureConfigurators(ProjectConfigurators.java:70)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation.synchronizeOpenWorkspaceProject(SynchronizeGradleBuildOperation.java:163)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation.synchronizeWorkspaceProject(SynchronizeGradleBuildOperation.java:137)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation.synchronizeGradleProjectWithWorkspaceProject(SynchronizeGradleBuildOperation.java:127)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation.access$000(SynchronizeGradleBuildOperation.java:42)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation$1.run(SynchronizeGradleBuildOperation.java:85)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2292)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2312)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation.synchronizeProjectsWithWorkspace(SynchronizeGradleBuildOperation.java:82)
	at org.eclipse.buildship.core.internal.workspace.SynchronizeGradleBuildOperation.run(SynchronizeGradleBuildOperation.java:64)
	at org.eclipse.buildship.core.internal.DefaultGradleBuild$SynchronizeOperation.runInToolingApi(DefaultGradleBuild.java:230)
	at org.eclipse.buildship.core.internal.operation.DefaultToolingApiOperationManager$WorkspaceRunnableAdapter.run(DefaultToolingApiOperationManager.java:58)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2292)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2317)
	at org.eclipse.buildship.core.internal.operation.DefaultToolingApiOperationManager.run(DefaultToolingApiOperationManager.java:39)
	at org.eclipse.buildship.core.internal.DefaultGradleBuild$SynchronizeOperation.run(DefaultGradleBuild.java:192)
	at org.eclipse.buildship.core.internal.DefaultGradleBuild.synchronize(DefaultGradleBuild.java:100)
	at org.eclipse.buildship.core.internal.workspace.SynchronizationJob.runInToolingApi(SynchronizationJob.java:64)
	at org.eclipse.buildship.core.internal.workspace.SynchronizationJob.runInToolingApi(SynchronizationJob.java:30)
	at org.eclipse.buildship.core.internal.operation.ToolingApiJob$1.runInToolingApi(ToolingApiJob.java:54)
	at org.eclipse.buildship.core.internal.operation.DefaultToolingApiOperationManager$WorkspaceRunnableAdapter.run(DefaultToolingApiOperationManager.java:58)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2292)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2317)
	at org.eclipse.buildship.core.internal.operation.DefaultToolingApiOperationManager.run(DefaultToolingApiOperationManager.java:39)
	at org.eclipse.buildship.core.internal.operation.ToolingApiJob.run(ToolingApiJob.java:65)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

breskeby · 2021-06-03T14:29:22Z

Haven't seen this locally. Will have a Look. Thanks for testing

breskeby · 2021-06-04T10:04:38Z

@nik9000 found the typo causing this. should be fixed

nik9000

That got it all working! There are other errors around groovy versions and module-path garbage when trying to run the build-tools but those aren't new. They are just what we get for not having an Eclipse user hack on the build consistently.

nik9000 · 2021-06-07T11:58:44Z

build-conventions/build.gradle

+         */
+        int i = 0;
+        classpath.getEntries().stream().filter(e -> e instanceof SourceFolder).forEachOrdered(s ->
+                s.setOutput("out/eclipse"+i)


I think this has the same error as the other stuff used to but it didn't fail because there is only one folder.

breskeby · 2021-06-08T12:23:31Z

@elasticmachine test this please

nik9000

LGTM

apply common eclipse config to all projects across the elasticsearch workspace including build tools projects

breskeby · 2021-06-08T14:39:07Z

fixed #73615

This reverts commit 3799abc

…73904)"" This reverts commit edd9597.

breskeby requested a review from nik9000 June 2, 2021 20:49

breskeby force-pushed the fix-eclipse-for-build-tools branch from 93a95bf to 124a104 Compare June 4, 2021 10:03

nik9000 approved these changes Jun 7, 2021

View reviewed changes

breskeby added 5 commits June 8, 2021 11:57

Fix eclipse configuration for build tools projects

6e4c9e8

Fix eclipse convention plugin

0748860

keep distinct output folders per sourceSet

8dc6f1d

Fix eclipse sourcefolder outputs for build convention

ee0b72c

Fix imports in build conventions

9f7d20e

breskeby force-pushed the fix-eclipse-for-build-tools branch from c8e93d7 to 9f7d20e Compare June 8, 2021 09:58

nik9000 approved these changes Jun 8, 2021

View reviewed changes

breskeby merged commit 6ff0b1b into elastic:master Jun 8, 2021

breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jun 8, 2021

Fix eclipse for build tools (elastic#73699)

fa7befe

apply common eclipse config to all projects across the elasticsearch workspace including build tools projects

breskeby mentioned this pull request Jun 8, 2021

Fix eclipse for build tools (#73699) (7.x backport) #73904

Merged

breskeby added a commit that referenced this pull request Jun 8, 2021

Fix eclipse for build tools (#73699) (7.x backport) (#73904)

3799abc

apply common eclipse config to all projects across the elasticsearch workspace including build tools projects

breskeby mentioned this pull request Jun 8, 2021

buildsrc not importing eclipse configuration #73615

Closed

mark-vieira added a commit that referenced this pull request Jun 9, 2021

Revert "Fix eclipse for build tools (#73699) (7.x backport) (#73904)"

edd9597

This reverts commit 3799abc

breskeby added a commit that referenced this pull request Jun 9, 2021

Revert "Revert "Fix eclipse for build tools (#73699) (7.x backport) (#…

f5ec26d

…73904)"" This reverts commit edd9597.

breskeby mentioned this pull request Jun 17, 2021

Update Gradle wrapper to 7.1 (7.x backport) #74225

Merged

breskeby deleted the fix-eclipse-for-build-tools branch December 10, 2024 13:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix eclipse for build tools #73699

Fix eclipse for build tools #73699

Uh oh!

breskeby commented Jun 2, 2021

Uh oh!

breskeby commented Jun 2, 2021

Uh oh!

nik9000 commented Jun 2, 2021

Uh oh!

nik9000 commented Jun 3, 2021

Uh oh!

breskeby commented Jun 3, 2021

Uh oh!

breskeby commented Jun 4, 2021

Uh oh!

nik9000 left a comment

Uh oh!

nik9000 Jun 7, 2021

Uh oh!

breskeby Jun 8, 2021

Uh oh!

breskeby commented Jun 8, 2021

Uh oh!

nik9000 left a comment

Uh oh!

breskeby commented Jun 8, 2021

Uh oh!

Uh oh!

Fix eclipse for build tools #73699

Fix eclipse for build tools #73699

Uh oh!

Conversation

breskeby commented Jun 2, 2021

Uh oh!

breskeby commented Jun 2, 2021

Uh oh!

nik9000 commented Jun 2, 2021

Uh oh!

nik9000 commented Jun 3, 2021

Uh oh!

breskeby commented Jun 3, 2021

Uh oh!

breskeby commented Jun 4, 2021

Uh oh!

nik9000 left a comment

Choose a reason for hiding this comment

Uh oh!

nik9000 Jun 7, 2021

Choose a reason for hiding this comment

Uh oh!

breskeby Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

breskeby commented Jun 8, 2021

Uh oh!

nik9000 left a comment

Choose a reason for hiding this comment

Uh oh!

breskeby commented Jun 8, 2021

Uh oh!

Uh oh!