[DOCS] Fix client_authentication setting default #73743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of `*.ssl.client_authentication` is `required` for everything except `xpack.security.http.ssl.client_authentication`, for which is it `none`. The doc template for this setting was configured to have a default value, and allow an override. However, the default was set to `none` when it should have been `required`. The override for `http` was correctly set to `none` (but that didn't really do anything, since that was the same as the default). This commit changes the default to `required`, which matches the code (see `XPackSettings.CLIENT_AUTH_DEFAULT`), and leaves the override for http as `none` (see `XPackSettings.HTTP_CLIENT_AUTH_DEFAULT`).
tvernum
added
>bug
>docs
elasticmachine
added
Team:Docs
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-security (Team:Security) |
ywangd
approved these changes
Jun 4, 2021
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Jun 4, 2021
The value of `*.ssl.client_authentication` is `required` for everything except `xpack.security.http.ssl.client_authentication`, for which is it `none`. The doc template for this setting was configured to have a default value, and allow an override. However, the default was set to `none` when it should have been `required`. The override for `http` was correctly set to `none` (but that didn't really do anything, since that was the same as the default). This commit changes the default to `required`, which matches the code (see `XPackSettings.CLIENT_AUTH_DEFAULT`), and leaves the override for http as `none` (see `XPackSettings.HTTP_CLIENT_AUTH_DEFAULT`). Backport of: elastic#73743
tvernum
added a commit
that referenced
this pull request
Jun 4, 2021
The value of `*.ssl.client_authentication` is `required` for everything except `xpack.security.http.ssl.client_authentication`, for which is it `none`. The doc template for this setting was configured to have a default value, and allow an override. However, the default was set to `none` when it should have been `required`. The override for `http` was correctly set to `none` (but that didn't really do anything, since that was the same as the default). This commit changes the default to `required`, which matches the code (see `XPackSettings.CLIENT_AUTH_DEFAULT`), and leaves the override for http as `none` (see `XPackSettings.HTTP_CLIENT_AUTH_DEFAULT`). Backport of: #73743
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Jun 4, 2021
The value of `*.ssl.client_authentication` is `required` for everything except `xpack.security.http.ssl.client_authentication`, for which is it `none`. The doc template for this setting was configured to have a default value, and allow an override. However, the default was set to `none` when it should have been `required`. The override for `http` was correctly set to `none` (but that didn't really do anything, since that was the same as the default). This commit changes the default to `required`, which matches the code (see `XPackSettings.CLIENT_AUTH_DEFAULT`), and leaves the override for http as `none` (see `XPackSettings.HTTP_CLIENT_AUTH_DEFAULT`). Backport of: elastic#73743
tvernum
added a commit
that referenced
this pull request
Jun 4, 2021
The value of `*.ssl.client_authentication` is `required` for everything except `xpack.security.http.ssl.client_authentication`, for which is it `none`. The doc template for this setting was configured to have a default value, and allow an override. However, the default was set to `none` when it should have been `required`. The override for `http` was correctly set to `none` (but that didn't really do anything, since that was the same as the default). This commit changes the default to `required`, which matches the code (see `XPackSettings.CLIENT_AUTH_DEFAULT`), and leaves the override for http as `none` (see `XPackSettings.HTTP_CLIENT_AUTH_DEFAULT`). Backport of: #73743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
*.ssl.client_authenticationisrequiredforeverything except
xpack.security.http.ssl.client_authentication, forwhich is it
none.The doc template for this setting was configured to have a default
value, and allow an override. However, the default was set to
nonewhen it should have been
required.The override for
httpwas correctly set tonone(but that didn'treally do anything, since that was the same as the default).
This commit changes the default to
required, which matches the code(see
XPackSettings.CLIENT_AUTH_DEFAULT), and leaves the override forhttp as
none(seeXPackSettings.HTTP_CLIENT_AUTH_DEFAULT).