Prevent deletion of snapshots that are used by snapshot backed indices #73821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>enhancement
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
I've seen two users with this problem in the last couple of weeks, so when a little birdy pointed me at this PR I'd thought I'd see if I could get things running again. I resolved the conflicts here from #74451 and #74977. There's a new test from #77686 that this is now failing against, I didn't touch that. I also didn't touch the Of course, I realize I'm taking liberties, and I wouldn't be offended at all if you force pushed my commits right back off. 😄 |
|
@tlrx I think this is still something we want right? |
|
Yes, this is supersedes by #79156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a check to prevent the deletion of snapshots that are used by searchable snapshots indices mounted in the same cluster.
This is work in progress since it conflicts with how ILM deletes snapshots of mounted indices.