Make Parsing SnapshotInfo more Efficient #74005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flatting the logic for parsing `SnapshotInfo` to go field by field like we do for `RepositoryData` which is both easier to read and also faster (mostly when moving to batch multiple of these blobs into one and doing on-the-fly filtering in an upcoming PR where the approach allows for more tricks). Also, simplified/deduplicated parsing out (mostly/often) empty lists in the deserialization code and used the new utility in a few more spots as well to save empty lists.
original-brownbear
added
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
reviewed
Jun 10, 2021
...r/src/main/java/org/elasticsearch/index/snapshots/blobstore/BlobStoreIndexShardSnapshot.java
Show resolved
Hide resolved
| this.indices = Collections.unmodifiableList(Objects.requireNonNull(indices)); | ||
| this.dataStreams = Collections.unmodifiableList(Objects.requireNonNull(dataStreams)); | ||
| this.featureStates = Collections.unmodifiableList(Objects.requireNonNull(featureStates)); | ||
| this.indices = List.copyOf(indices); |
There was a problem hiding this comment.
Do these changes translate to 7.x ok? I guess we'll end up using org.elasticsearch.core.List#copyOf which does a complete copy every time...
There was a problem hiding this comment.
Sort of ... I think we should fix the copy of behavior in 7.x if it's inefficient in this spot but still nice to not have 5x deep nesting on this list in any case I guess :) I'll look into a 7.x fix of that method later/next-week :)
|
Thanks David! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jun 13, 2021
Flatting the logic for parsing `SnapshotInfo` to go field by field like we do for `RepositoryData` which is both easier to read and also faster (mostly when moving to batch multiple of these blobs into one and doing on-the-fly filtering in an upcoming PR where the approach allows for more tricks). Also, simplified/deduplicated parsing out (mostly/often) empty lists in the deserialization code and used the new utility in a few more spots as well to save empty lists.
original-brownbear
added a commit
that referenced
this pull request
Jun 13, 2021
Flatting the logic for parsing `SnapshotInfo` to go field by field like we do for `RepositoryData` which is both easier to read and also faster (mostly when moving to batch multiple of these blobs into one and doing on-the-fly filtering in an upcoming PR where the approach allows for more tricks). Also, simplified/deduplicated parsing out (mostly/often) empty lists in the deserialization code and used the new utility in a few more spots as well to save empty lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatting the logic for parsing
SnapshotInfoto go field by field like we do forRepositoryDatawhich is both easier to read and also faster (mostly when moving to batch multiple of these blobs into one
and doing on-the-fly filtering in an upcoming PR where the approach allows for more tricks).
Also, optimized/deduplicated the logic for parsing out (mostly/often) empty lists in the deserialization code
and used the new utility in a few more spots as well to save empty lists.
Lastly, fixed the at times very deeply nested
Collections.unmodifiableList(chains that the way the duplicate constructors for x-content parsing and normal construction would cause.