Avoid multiline check-index log messages #74303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we filter out multiline log messages on Windows, preventing us from asserting that they are emitted. This commit replaces some multi-line log messages with multiple single-line log messages to fix `IndexShardTests#testIndexCheckOnStartup` on Windows. Relates elastic#74233 Closes elastic#74299
DaveCTurner
added
>bug
:Distributed Indexing/Recovery
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
tlrx
approved these changes
Jun 18, 2021
|
I have tested this on windows and this fixes the problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we filter out multiline log messages on Windows, preventing us
from asserting that they are emitted. This commit replaces some
multi-line log messages with multiple single-line log messages to fix
IndexShardTests#testIndexCheckOnStartupon Windows.Relates #74233
Closes #74299