Skip to content

Allow opting out of known Lucene file extensions check #74316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Jun 18, 2021

Allows plugin developers of custom codecs to opt out of the assertion in LuceneFilesExtensionsTests that checks that all encountered Lucene file extensions are known to this class. In the future, we would like to add a proper plugin extension point for this.

Relates #74150

@ywelsch ywelsch added >non-issue :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.14.0 labels Jun 18, 2021
@ywelsch ywelsch requested a review from tlrx June 18, 2021 14:50
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jun 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywelsch ywelsch merged commit 632901f into elastic:master Jun 21, 2021
ywelsch added a commit that referenced this pull request Jun 21, 2021
Allows plugin developers of custom codecs to opt out of the assertion in LuceneFilesExtensionsTests that checks that all
encountered Lucene file extensions are known to this class. In the future, we would like to add a proper plugin extension
point for this.

Relates #74150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants