-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Data Tier correlation for searchable_snapshot mount location #74706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Per andrei's wisdom on elastic/sdh-elasticsearch#4555 (comment)
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed (Team:Distributed) |
Pinging @elastic/es-core-features (Team:Core/Features) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this clarification @stefnestor.
In addition to your change, I added a sentence to make it clearer that the action requires data tiers. I also moved the last sentence to the first paragraph.
This LGTM, but I'll wait on @andreidan's review before merging.
@elasticmachine retest this please |
1 similar comment
@elasticmachine retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a minor suggestion, thanks for working on this Stef!
the data stream. | ||
the stream. | ||
|
||
The `searchable_snapshot` action requires <<data-tiers,data tiers>>. In the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we expand this a bit and say something like:
The `searchable_snapshot` action requires a system that uses <<data-tiers,data tiers>>
as it will mount the index directly on the corresponding tier using the
<<tier-preference-allocation-filter, `index.routing.allocation.include._tier_preference`>> setting.
Maybe @jrodewig has a better suggestion here? (I don't particularly like "a system that uses ..." but not sure how else to phrase this).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andreidan. I pushed some changes to incorporate the index.routing.allocation.include._tier_preference
setting content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks James
@elasticmachine run elasticsearch-ci/docs |
) (#74764) Co-authored-by: Stef Nestor <[email protected]>
) (#74765) Co-authored-by: Stef Nestor <[email protected]>
) (#74771) Co-authored-by: Stef Nestor <[email protected]>
@jrodewig can we also back port this applicable info to 7.12, 7.11, & 7.10? I know we back ported to 7.x (thank you!), but if we still back port to the other version it'd help as well. 🙏🏼 |
Hi @stefnestor. Thanks for reaching out. Per our backport guidelines, we typically don't backport doc changes to out-of-maintenance versions. However, I'll work on getting these in as it seems to be a problem point. |
) (#75255) Co-authored-by: Stef Nestor <[email protected]>
) (#75257) Co-authored-by: Stef Nestor <[email protected]>
) (#75254) Co-authored-by: Stef Nestor <[email protected]>
Per @andreidan wisdom:
This points out the prerequisite of the corresponding data tier for the searchable_snapshot phase.