Simplify Stacktrace in GCS Streaming Upload Logic #74716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aside from simplifying the code (the close is unnecessary) this change fixes access control checks breaking on Java 8 in 7.x.
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
System test disregard |
|
Jenkins test this |
|
@elasticmachine test this please |
|
Thanks Francisco! |
|
Too fast for me 😀 |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jun 30, 2021
Aside from simplifying the code (the close is unnecessary) this change fixes access control checks breaking on Java 8 in 7.x.
original-brownbear
added a commit
that referenced
this pull request
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from simplifying the code (the close is unnecessary since it's a noop on
WritableBlobChannelanyway ) this change fixes access control checks breaking on Java 8 in 7.x. (see seemingly inexplicable test failure https://gradle-enterprise.elastic.co/s/tu563yn6doobg/console-log/raw for an example)