Skip to content

Fix unit test classpath when testing shadow jar projects #74783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

mark-vieira
Copy link
Contributor

The pull request sorts out a configuration ordering issue when modifying unit test task classpaths to test against a shadow jar instead of the normal classes directory. Instead of trying to mutate the existing task's classpath, we use the test sourceset runtime classpath isntead. We also limit this to only apply to unit test (i.e. the test task).

@mark-vieira mark-vieira added >non-issue :Delivery/Build Build or test infrastructure auto-backport Automatically create backport pull requests when merged v7.14.1 v7.15.0 labels Jun 30, 2021
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Jun 30, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@mark-vieira
Copy link
Contributor Author

@elasticmachine update branch

@mark-vieira mark-vieira merged commit 8bbba5f into elastic:master Jun 30, 2021
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
7.14 Error pushing to https://github.com/elasticsearchmachine/elasticsearch. Repository does not exist. Either fork the source repository (https://github.com/elastic/elasticsearch) or disable fork mode "--fork false". Read more about "fork mode" in the docs: https://github.com/sqren/backport/blob/3a182b17e0e7237c12915895aea9d71f49eb2886/docs/configuration.md#fork
7.x Error pushing to https://github.com/elasticsearchmachine/elasticsearch. Repository does not exist. Either fork the source repository (https://github.com/elastic/elasticsearch) or disable fork mode "--fork false". Read more about "fork mode" in the docs: https://github.com/sqren/backport/blob/3a182b17e0e7237c12915895aea9d71f49eb2886/docs/configuration.md#fork

To backport manually run:
backport --pr 74783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v7.14.0 v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants