Update licenses and attributions for GeoIP module #75178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probakowski
added
>non-issue
:Data Management/Ingest Node
|
Pinging @elastic/es-core-features (Team:Core/Features) |
probakowski
added
the
auto-backport
|
@elasticmachine update branch |
jakelandis
reviewed
Jul 14, 2021
There was a problem hiding this comment.
Should these files be part of the assembly ? I am not seeing any of these files in the assembly.
git log -1
commit 65364385bbd041cf622e5dfe155b61da895fd86e (HEAD -> geoip-licenses)
./gradlew assemble
cd distribution/archives/linux-tar/build/distributions/
tar xfz elasticsearch-8.0.0-SNAPSHOT-linux-x86_64.tar.gz
find elasticsearch-8.0.0-SNAPSHOT -name *LICENSE.txt
...ternal/src/main/java/org/elasticsearch/gradle/internal/precommit/DependencyLicensesTask.java
Outdated
Show resolved
Hide resolved
|
@breskeby - can you take a look at the Gradle bits ? Also do you know if these files should be included in the assembly ? |
breskeby
previously requested changes
Jul 15, 2021
...ools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/LicenseAnalyzer.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
|
@probakowski - do you know if these files should be included in the assembly (i.e. the tar/zip/etc.) or just the source ? |
|
LGTM. As discussed offline, lets go ahead and get this in the source and we can figure out if this should or should not be in the final assembly and if so can include it in a different PR. |
probakowski
dismissed
breskeby’s stale review
Requested changes have been applied
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 26, 2021
Update licenses and attributions for GeoIP module
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 26, 2021
Update licenses and attributions for GeoIP module
elasticsearchmachine
added a commit
that referenced
this pull request
Jul 26, 2021
…5683) * Update licenses and attributions for GeoIP module (#75178) Update licenses and attributions for GeoIP module * fix Co-authored-by: Przemko Robakowski <[email protected]>
elasticsearchmachine
added a commit
that referenced
this pull request
Jul 26, 2021
) * Update licenses and attributions for GeoIP module (#75178) Update licenses and attributions for GeoIP module * fix Co-authored-by: Przemko Robakowski <[email protected]>
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
Update licenses and attributions for GeoIP module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update licenses and attributions for GeoIP module