Skip to content

[Rest Api Compatibility] Always return adjust_pure_negative value #75182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

[Rest Api Compatibility] Always return adjust_pure_negative value #75182

merged 1 commit into from
Jul 12, 2021

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jul 9, 2021

the adjust_pure_negative value used to be always present in to_xcontent
response, but it was changed in #49543 to only serialise this field when
the value is false

relates #51816

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
[Rest Api Compatibility] Return adjust_pure_negative values
185ecbe 
the adjust_pure_negative value used to be always present in to_xcontent
response, but it was changed in elastic#49543 to only serialise this field when
the value is false

relates elastic#51816
@pgomulka pgomulka added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 labels Jul 9, 2021
@pgomulka pgomulka self-assigned this Jul 9, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 9, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka pgomulka changed the title [Rest Api Compatibility] Return adjust_pure_negative values [Rest Api Compatibility] Always return adjust_pure_negative value Jul 9, 2021
@pgomulka pgomulka requested a review from markharwood July 9, 2021 13:19
markharwood
markharwood approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@markharwood markharwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit 563e1fb into elastic:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markharwood markharwood markharwood approved these changes

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgomulka @elasticmachine @markharwood @jakelandis