[Rest Api Compatibility] Allow transforming warnings per test #75187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgomulka
changed the title
|
@elasticmachine run elasticsearch-ci/part-1 |
jakelandis
approved these changes
Jul 14, 2021
| @@ -298,6 +307,14 @@ public void addAllowedWarningRegex(String... allowedWarningsRegex) { | |||
| transformations.add(new InjectAllowedWarnings(true, Arrays.asList(allowedWarningsRegex))); | |||
| } | |||
|
|
|||
| /** | |||
| * Adds one or more allowed regular expression warnings | |||
| * @param allowedWarningsRegex the regex warning(s) to add | |||
There was a problem hiding this comment.
nit: javadoc for testName
|
@elasticmachine update branch |
masseyke
pushed a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 16, 2021
…c#75187) Warning related transformations missed the possibility to apply per single test only. Also a warning changed in elastic#67158 for indices.close so this PR also applies the transformation for 7.x test relates elastic#51816
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
…c#75187) Warning related transformations missed the possibility to apply per single test only. Also a warning changed in elastic#67158 for indices.close so this PR also applies the transformation for 7.x test relates elastic#51816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning related transformations missed the possibility to apply per single test only.
Also a warning changed in #67158 for indices.close so this PR also applies the transformation for 7.x test
relates #51816