Skip to content

Docs: Fix watcher main title #75220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2021
Merged

Conversation

spinscale
Copy link
Contributor

The docs list a confusing paragraph named Watch for cluster and index events which contains the whole watcher documentation. That should probably be named with something like watcher in its name.

image

@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Jul 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig
Copy link
Contributor

Thanks @spinscale. I pushed fbdd38c to change the title and include "Watcher" in the intro paragraph.

From what I understand, Kibana Alerting is now preferred. We likely don't want to confuse users by using "Alerting" in the title here.

I'd like to get @debadair's feedback before merging this in. Thanks again for raising this!

@spinscale
Copy link
Contributor Author

side note: In the Kibana docs it gets referred as 'Elasticsearch Alerting', so we should probably just make sure that nomenclature is in sync. See https://www.elastic.co/guide/en/kibana/7.x/alerting-getting-started.html#alerting-concepts-differences

@jrodewig
Copy link
Contributor

Thanks @spinscale. I agree. If we make this title change, we should also update that reference in the Kibana docs.

@joegallo joegallo added v7.13.5 and removed v7.13.4 labels Jul 19, 2021
@jrodewig
Copy link
Contributor

@elasticmachine update branch

@jrodewig
Copy link
Contributor

jrodewig commented Jul 22, 2021

Spoke with @debadair offline, and she's good with these changes. I'm going to merge this in and backport it.

I've opened elastic/kibana#106565 to update the reference in the Kibana docs. Thanks again @spinscale!

@jrodewig
Copy link
Contributor

@elasticmachine update branch

@jrodewig jrodewig removed the request for review from debadair July 22, 2021 16:37
jrodewig added a commit to elastic/kibana that referenced this pull request Jul 22, 2021
Kibana Alerting is now the preferred method for alerting in Elastic. To avoid confusion, we should use "Watcher" and avoid terms like "Elasticsearch alerting."

This updates a reference on the Alerting page. Relates to elastic/elasticsearch#75220
@jrodewig jrodewig merged commit 25c5707 into elastic:master Jul 22, 2021
jrodewig added a commit to elastic/kibana that referenced this pull request Jul 22, 2021
Kibana Alerting is now the preferred method for alerting in Elastic. To avoid confusion, we should use "Watcher" and avoid terms like "Elasticsearch alerting."

This updates a reference on the Alerting page. Relates to elastic/elasticsearch#75220
jrodewig added a commit to elastic/kibana that referenced this pull request Jul 22, 2021
Kibana Alerting is now the preferred method for alerting in Elastic. To avoid confusion, we should use "Watcher" and avoid terms like "Elasticsearch alerting."

This updates a reference on the Alerting page. Relates to elastic/elasticsearch#75220
jrodewig added a commit to elastic/kibana that referenced this pull request Jul 22, 2021
Kibana Alerting is now the preferred method for alerting in Elastic. To avoid confusion, we should use "Watcher" and avoid terms like "Elasticsearch alerting."

This updates a reference on the Alerting page. Relates to elastic/elasticsearch#75220
elasticsearchmachine pushed a commit that referenced this pull request Jul 22, 2021
Simplifies the Watcher chapter's title to "Watcher."

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: Alexander Reelsen <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jul 22, 2021
Simplifies the Watcher chapter's title to "Watcher."

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: Alexander Reelsen <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jul 22, 2021
Simplifies the Watcher chapter's title to "Watcher."

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: Alexander Reelsen <[email protected]>
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
Simplifies the Watcher chapter's title to "Watcher."

Co-authored-by: James Rodewig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Watcher >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.13.5 v7.14.0 v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants