-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Fix test version and index creation #75534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes test skip version, which was incorrect before. It also removes a duplicate index creation, as the index is already created during setup stage. Related to elastic#50709
Pinging @elastic/es-search (Team:Search) |
cbuescher
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cbuescher Thanks for the quick review. |
mayya-sharipova
added a commit
that referenced
this pull request
Jul 20, 2021
This patch fixes test skip version, which was incorrect before. It also removes a duplicate index creation, as the index is already created during setup stage. Related to #50709
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jul 21, 2021
The test in 7.x was fixed in elastic#75534
pgomulka
added a commit
that referenced
this pull request
Jul 21, 2021
The test in 7.x was fixed in #75534
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
…75560) The test in 7.x was fixed in elastic#75534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Search/Search
Search-related issues that do not fall into other categories
Team:Search
Meta label for search team
>test
Issues or PRs that are addressing/adding tests
v7.14.0
v7.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes test skip version, which was incorrect before.
It also removes a duplicate index creation, as the index is already created
during setup stage.
Related to #50709