Aggregations: Adds ability to sort on multiple criteria #7588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -239,6 +306,13 @@ public static InternalOrder readOrder(StreamInput in) throws IOException { | |||
| return new InternalOrder.Aggregation(key + "." + in.readString(), asc); | |||
| } | |||
| return new InternalOrder.Aggregation(key, asc); | |||
| case -1: | |||
There was a problem hiding this comment.
Can you use CompoundOrder.ID instead of -1?
|
@jpountz Didn't realise that you hadn't removed the review tag but have just pushed an update from your feedback. Sorry if that messes things up |
| public static class CompoundOrderComparator implements Comparator<Terms.Bucket> { | ||
|
|
||
| private List<Terms.Order> compoundOrder; | ||
| private Aggregator aggregator; |
|
LGTM |
The terms aggregation can now support sorting on multiple criteria by replacing the sort object with an array or sort object whose order signifies the priority of the sort. The existing syntax for sorting on a single criteria also still works. Contributes to #6917
|
These changes have been reverted as backward compatibility issues were found. A new PR will be raised when the issues have been resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The terms aggregation can now support sorting on multiple criteria by replacing the sort object with an array or sort object whose order signifies the priority of the sort. The existing syntax for sorting on a single criteria also still works.
Contributes to #6917