Skip to content

[7.x] Create data stream aliases from component templates (#75956) #76137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

danhermann
Copy link
Contributor

#73867 added the ability to create data stream aliases but only from aliases defined in the top-level composable template. This amends that to include aliases defined in any component templates included in the composable template.

Relates to #66163

Backport of #75956

@danhermann danhermann requested a review from martijnvg August 4, 2021 23:09
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Aug 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

* immediately after an upgrade the failure should be optional. So that there is time to change
* these templates. The logic that adds/updates index and component templates shouldn't skip this
* validation.
* Resolve the given v2 template name into an ordered list of aliases
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martijnvg, could you confirm that the failIfTemplateHasDataStream parameter is no longer necessary here? I believe it was used only to verify that data stream templates do not create aliases which is no longer true.

@danhermann danhermann merged commit 1864a68 into elastic:7.x Aug 17, 2021
@danhermann danhermann deleted the backport_7x_75956_create_ds_alias_from_component_template branch August 17, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Data Management/Data streams Data streams and their lifecycles >non-issue Team:Data Management Meta label for data/management team v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants